New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No longer works OOB on macOS 12.3 #27
Comments
We’ll that could def be the problem!!! It’s on my todo list to look at this. There is just so much other stuff going on. Maybe I can take a look this evening
…Sent from my iPhone
On Jan 31, 2022, at 2:53 AM, Kimberly Grey ***@***.***> wrote:
Emoji Taco v1.2.3 — macOS 12.3 beta.
I've just updated to the macOS 12.3 beta that dropped a couple of days ago (I live dangerously) and Emoji Taco no longer works. No errors or glitches, anything after the initial Alfred keywords (aka, involves running a python script) just doesn't work.
My assumption is that this is because macOS 12.3 removes the bundled version of Python 2 (something Apple apparently said they were going to do in 2019). Bit weird of them to do that in a minor release, but that's Apple for ya.
Just giving a head's up in case no one has pointed this out yet!
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
|
I'm assuming 2 possible things:
|
Running I do have Python 3 installed ( |
So you are saying that out of the box the latest beta doesn't have any python? Or only has python3? I mean that's going to be a huger Alfred issue all together... |
So I'm using this library: https://github.com/deanishe/alfred-workflow which hasn't been updated to Python3.... but I'm still confused about the beta osx situation with which python is available |
Not sure if this would help. But have a look. |
Please see https://www.alfredapp.com/help/kb/python-2-monterey/ Installing python 2 via these instructions still results in "python: command not found" errors in the debugging console for the workflow. Changing "python" in the three script filters to "/usr/local/bin/python" (i.e. to hardcode the newly Homebrew-installed python 2.7 binary) gives this set of errors:
|
Looks like the background download script is still calling |
I got it mostly working by
Init Emoji says that it parses 2,243 emoji, and many searches work as expected: but there are some obvious ones now missing? Hmm. I don't see anything in the debug output that stands out. |
Ah. I see that the no-peach issue is a separate one: #24 |
@jeeftor Go into your three script filters and make the first line: export PATH="/opt/homebrew/bin:/usr/local/bin:${PATH}" That won’t make a difference to anyone using the Workflow now, and for people who are on Monterey 12.3 and followed the knowledge base article, it will work as well. |
Unfortunately, that updated PATH won't fix the workflow by itself because several hardcoded references to /usr/bin/python remain: @jeeftor if you add the PATH to the script filters per @vitorgalvao and change each of those seven '/usr/bin/python' instances to just 'python' (you don't want to hardcode e.g. /usr/local/bin/python because Homebrew only installs in that location on Intel; on M1 the binary will be at /opt/homebrew/bin/python), then the script works, #24 notwithstanding. |
just installed 12.3. sacrebleu. missing my tacos emojis. edit: this was supposed to contain the frown emoji but hey. |
Sorry guys -> I've been way behind working on other projects... :(
And my version keeps working and working... (so its hard to debug this
stuff)
…On Tue, Mar 15, 2022 at 4:42 AM G. ***@***.***> wrote:
just installed 12.3. sacrebleu. missing my tacos emojis.
—
Reply to this email directly, view it on GitHub
<#27 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABRQ4XZ2Z5R5NNUW4ZTK4RDVABSS7ANCNFSM5NFYRRVQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
There’s nothing to debug; it’s not a problem with your code but with the tooling it relies on. The Workflow will break for everyone on 12.3—including you—because the Python runtime is no longer present. For the Workflow to keep working you’ll have to either do the changes I and @ilikepeaches pointed out above (like so1) and instruct people to install Python2 or port the Workflow to Python3 (or another language). Footnotes
|
no worries man. if i get a bit better at Python i'll have a look. thanks again for the tacos! |
I just ordered a new Mac today (6-8 weeks) -> so I'll likely have to fix this automation when it arrives... So at least thats on the horizon. So I promise it will eventually get done as soon as it stops working for me |
I lied ... i'm working on the code a bit today - but no promises |
Probably wont be done today but i've got a py3 branch that i'm working on locally (outside of alfred) with only And running into a few python 2-3 issues :) |
So I have the code now running with python3 BUT python3 handles unicode / emojis differently so I need to dig through that. Also making a ton of improvements that probably none of you guys care about like adding more comments and return types (totally for readability not for usefulness) |
https://github.com/jeeftor/EmojiTaco/releases/tag/py3 I haven't really had time to test this so its a crapshoot - but in theory it might kinda work |
are you kidding. clean and tight code is sexy af. 😍 |
I realized I forgot to update the script commands Alfred actually calls ... oops |
Need to set pythonpath I think and python3 in the scripts if you are so motivated. I'll try tomorrow |
So if somebody feels like testing stuff - I think your script commands need to look something like this: SEARCH TASK PYTHONPATH=$(pwd)/src/libs python3 src/esearch.py taco INIT TASK # No longer needed probably
# find . -name '*.so' | xargs xattr -d -r com.apple.quarantine
PYTHONPATH=$(pwd)/src/libs python3 src/downloadDataFiles.py for your execution script on the search call for example One caveat which may / may not cause issues: In the background downloading script I'm calling |
If you’re using an unmodified |
@jeeftor lukewaite/alfred-gitlab#27 might help. I've also successfully used it to port another workflow of mine to |
I'll push out another test shortly ... its going to be a bit shall we say hacky - but it might work. The main issue is you will have to run I dont like that but its potentially where things are at right now 😠 |
ugh... looks like my release script also needs updates :( |
https://github.com/jeeftor/EmojiTaco/releases/tag/v1.2.15 Ok I pushed a new release. Main issue is that So run that wait like 5-10 mins and then try to search for emoji and give me some feedback. Won't likely try again to fix stuff until tomorrow... |
|
My suspicion is the way that strings work in Python2 vs Python3 unicode strings are different... I may take a pause on this workflow until I can port my progress bar: over to Python3 in which case it might solve some of the issues. Its a MUCH simpler codebase I think There are also other issues ... but see if you can search emoji right now... |
Downloading and processing works -> its just the actual plugin that returns unicode strings and not the actual emoji that needs a patch |
i'm currently back to using EmojiTaco and it's awesome. even with the unicode string \U0001F600\U0000FE0F \U0001F44D\U0000FE0F |
I just need some more boring meetings and I can finish this off :) |
\U0001F64F\U0000FE0F |
🌮️🍖️🥩️ It Works!! (Expect a new release tonight/tomorrow) |
https://github.com/jeeftor/EmojiTaco/releases/tag/v2.0.0-beta-1 Lemme know what bugs I've added! |
e frown |
Same error on init and debug?
…Sent from my iPhone
On Apr 5, 2022, at 11:47 PM, G. ***@***.***> wrote:
[13:46:17.150] ERROR: Emoji Taco[[Script Filter](alfredpreferences:workflows%3Eworkflow%3Euser.workflow.CD0D6581-5808-4A7F-AE02-0A490C0AE922%3E157AEB44-CD30-445B-B751-7CEDE94BC8A0)] Code 1: Traceback (most recent call last):
File "src/esearch.py", line 8, in <module>
from workflow import Workflow3
ModuleNotFoundError: No module named 'workflow'
e frown
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.
|
@jeeftor The workflow folder is missing in https://github.com/jeeftor/EmojiTaco/tree/py3/src. Maybe you just forgot to commit it? :) |
Yea I realized that. It's a symlink which I assumed would be included if I directly exported from Alfred. I'm updating the workflow lib at the same time. I'll push an update today |
hehe that's a classic one. same thing for me when i develop a workflow.
so i guess you know by now but yes. had tested all commands, different modules needed but same error. hadn't check the source tho (busy coding!). |
🙈️ |
aww 😍️ |
ok it didn't work the first time i've launched it. ran |
thank you! life is good again. |
Does "trying again" help at all for the init once it times out?
…On Wed, Apr 6, 2022 at 10:08 AM Patrick Schratz ***@***.***> wrote:
Feedback on v2.0.2
init emoji seems to be stuck in a loop (quitted after 5 mins):
[image: image]
<https://user-images.githubusercontent.com/8430564/162018687-1636dcad-2c2c-48d4-99f9-3f64d7ce88c3.png>
And I am still missing the preview thumbnails - but the copied emojies
work and I can paste them 👍
—
Reply to this email directly, view it on GitHub
<#27 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABRQ4XYBA3YDWCZMEREQWYDVDWZHHANCNFSM5NFYRRVQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Emoji Taco v1.2.3 — macOS 12.3 beta.
I've just updated to the macOS 12.3 beta that dropped a couple of days ago (I live dangerously) and Emoji Taco no longer works. No errors or glitches, anything after the initial Alfred keywords (aka, involves running a python script) just doesn't work.
My assumption is that this is because macOS 12.3 removes the bundled version of Python 2 (something Apple apparently said they were going to do in 2019). Bit weird of them to do that in a minor release, but that's Apple for ya.
Just giving a head's up in case no one has pointed this out yet!
The text was updated successfully, but these errors were encountered: