Fixed 'embed' option, it will now work when set to 'true' #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
generatorConfig will now use the value from the config using key 'embed' with a boolean of true or false - this is already documented in the readme but it did not work
for best practise and performance, base64 encode files in the example - really this could be default
increased version to 2.0.4 as is non-breaking change
jeerbl
reviewed
Sep 10, 2017
package.json
Outdated
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "webfonts-loader", | |||
| "version": "2.0.3", | |||
| "version": "2.0.4", | |||
There was a problem hiding this comment.
You shouldn't update the version manually. Put it back to 2.0.3 NPM will handle it ;)
added 'embed' key to 'generatorConfiguration' object, as when 'writeFiles' is set to 'true' it creates a duplicate copy of the font files in the root of the project
|
Ready to merge @jeerbl 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wired up 'embed' boolean option to 'writeFiles' ...generatorConfig will now use the value from the config using key 'embed' with a boolean of true or false - this is already documented in the readme but it did not work
test example config should embed font files …for best practise and performance, base64 encode files in the example - really this could be default
Please can you merge and push new version into NPM for v2.0.4 to resolve this issue :)