Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Low resolution in Windows #20

Closed
arash-ashra opened this issue Sep 20, 2022 · 11 comments · Fixed by #22
Closed

[BUG] Low resolution in Windows #20

arash-ashra opened this issue Sep 20, 2022 · 11 comments · Fixed by #22
Labels
bug Something isn't working present Related to the main "present" feature windows Windows related

Comments

@arash-ashra
Copy link

arash-ashra commented Sep 20, 2022

Hi there. Thank you so much for maintaining this.

Unfortunately, I couldn't get the HD resolution in Windows. Here's how it looks like:
image
but supposed to be:
image

I tried setting the resolution to 1920x1080, but it didn't work.

@jeertmans
Copy link
Owner

Hi @arashash , thank you for your issue!

I just tested a fix in Windows and it seems to work quite well, see #22 . Would you mind testing it?

You can install it using:

pip install git+https://github.com/jeertmans/manim-slides@fix-window-quality

@arash-ashra
Copy link
Author

Thank you so much @jeertmans
It looks much better now:
image

@arash-ashra
Copy link
Author

Is there a way to increase the quality further?

@jeertmans
Copy link
Owner

Did you try to increase the rendering quality?
On my side, I will try different interpolation methods.

@arash-ashra
Copy link
Author

arash-ashra commented Sep 20, 2022

yea, I tried:
manim-slides SkipConnection --fullscreen --resolution 1920 1080

btw I'm wondering if we could skip the resizing step if the fullscreen resolution matches the video? I think that's a very common use case. Since generally we have HD resolution in videos and operating system

@jeertmans
Copy link
Owner

I removed the "useless" resizing when resolutions match. However, --fullscreen resolution does not seem to match HD resolution, at least on my desktop (even though it should, I think).

Then, I added an optional flag for interpolation method, because I can't really see one that is better than all the others.

@arash-ashra
Copy link
Author

Yea I tried with all the flags and didn't see a difference

@jeertmans
Copy link
Owner

Yeah… I really don’t know why I can’t have the same quality on Windows and on Linux…

And what happens if you increasing the rendering quality (so with manim or manimgl)?

@arash-ashra
Copy link
Author

I think I found the issue. In windows, there's the option of scaling:
image
When I set it to 100 it looks perfect:
image

@jeertmans
Copy link
Owner

Wow, nice! Where is this option? I might document that in the README.

@arash-ashra
Copy link
Author

Yaay! On the main page of settings.
image

@jeertmans jeertmans added bug Something isn't working present Related to the main "present" feature windows Windows related labels Apr 4, 2024
@jeertmans jeertmans changed the title Low resolution in Windows [BUG] Low resolution in Windows Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working present Related to the main "present" feature windows Windows related
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants