Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): PySide6 player black screen #297

Merged
merged 1 commit into from
Oct 23, 2023
Merged

fix(deps): PySide6 player black screen #297

merged 1 commit into from
Oct 23, 2023

Conversation

jeertmans
Copy link
Owner

Fixes #293

@jeertmans jeertmans added dependencies Pull requests that update a dependency file present Related to the main "present" feature labels Oct 23, 2023
@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

Attention: 45 lines in your changes are missing coverage. Please review.

Files Coverage Δ
manim_slides/__init__.py 60.00% <100.00%> (ø)
manim_slides/__main__.py 71.42% <100.00%> (-0.67%) ⬇️
manim_slides/commons.py 96.15% <ø> (ø)
manim_slides/config.py 82.75% <100.00%> (-1.16%) ⬇️
manim_slides/logger.py 100.00% <100.00%> (ø)
manim_slides/present/player.py 76.62% <100.00%> (ø)
manim_slides/slide/manimlib.py 100.00% <100.00%> (ø)
manim_slides/slide/animation.py 97.56% <97.56%> (ø)
manim_slides/utils.py 89.74% <83.33%> (-2.15%) ⬇️
manim_slides/convert.py 87.63% <72.72%> (+13.44%) ⬆️
... and 6 more

📢 Thoughts on this report? Let us know!.

@jeertmans jeertmans merged commit 56b1ffe into main Oct 23, 2023
19 of 20 checks passed
@jeertmans jeertmans deleted the fix-pyside6 branch October 23, 2023 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file present Related to the main "present" feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Slides go black when video finishes
1 participant