Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lib): add auto_next option #304

Merged
merged 2 commits into from
Oct 30, 2023
Merged

feat(lib): add auto_next option #304

merged 2 commits into from
Oct 30, 2023

Conversation

jeertmans
Copy link
Owner

As suggested in #302, you can now automatically skip a slide. It works both with present and convert --to=html!

Closes #302

As suggested in #302, you can now automatically skip a slide. It works both with `present` and `convert --to=html`!

Closes #302
@jeertmans jeertmans added enhancement New feature or request html-convert Related to converting to HTML slides lib Related to the library (a.k.a. module) present Related to the main "present" feature labels Oct 30, 2023
@@ -48,6 +48,10 @@ In an effort to better document changes, this CHANGELOG document is now created.
[#295](https://github.com/jeertmans/manim-slides/pull/295)
- Added `--playback-rate` option to `manim-slides present` for testing purposes.
[#300](https://github.com/jeertmans/manim-slides/pull/300)
- Added `auto_next` option to `Slide`'s `next_slide` method to automatically
play the next slide upon terminating. Supported by `present` and
`convert --to=html` commands.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[LanguageTool] reported by reviewdog 🐶
File types are normally capitalized. (FILE_EXTENSIONS_CASE[1])
Suggestions: HTML
URL: https://languagetool.org/insights/post/spelling-capital-letters/
Rule: https://community.languagetool.org/rule/show/FILE_EXTENSIONS_CASE?lang=en-US&subId=1
Category: CASING

@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Files Coverage Δ
manim_slides/config.py 91.50% <100.00%> (+0.46%) ⬆️
manim_slides/convert.py 88.59% <100.00%> (+0.95%) ⬆️
manim_slides/slide/base.py 96.26% <100.00%> (ø)
manim_slides/slide/manim.py 92.15% <100.00%> (ø)
manim_slides/present/player.py 80.50% <0.00%> (-1.39%) ⬇️

📢 Thoughts on this report? Let us know!.

@jeertmans jeertmans merged commit 6c52906 into main Oct 30, 2023
19 of 21 checks passed
@jeertmans jeertmans deleted the auto-next branch October 30, 2023 09:13
@Adcombrink
Copy link

Nice! Thanks for adding this, good work!

@jeertmans
Copy link
Owner Author

Thanks @Adcombrink!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request html-convert Related to converting to HTML slides lib Related to the library (a.k.a. module) present Related to the main "present" feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Automatically skip some slide
2 participants