perf: check internet with DNS lookup #1034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DNS lookups are much cheaper than HTTP requests since we only need to check if the Internet is available. See: https://stackoverflow.com/a/50058255
jeessy2
reviewed
Mar 25, 2024
|
|
||
| const ( | ||
| // fallbackDNS used when a fallback occurs. | ||
| fallbackDNS = "1.1.1.1" |
There was a problem hiding this comment.
是不是这里的，默认1.1.1.1可能会把自定义的dns覆盖，有些地区1.1.1.1可能不通
There was a problem hiding this comment.
是不是这里的，默认1.1.1.1可能会把自定义的dns覆盖，有些地区1.1.1.1可能不通
想一下用哪个国内的 DNS 比较好。
另外，感觉是不是应该更严格一点，失败多次再回落？
There was a problem hiding this comment.
可以考虑失败多次再回落，回落可以多个，国内主流的，如223.5.5.5 114.114.114.114
There was a problem hiding this comment.
如果有自定义的DNS，只使用自定义DNS，回落也不回落到公共DNS
如果没有自定义的DNS，根据浏览器语言来回落不同DNS？
There was a problem hiding this comment.
除非用户手动指定，否则按原样使用默认 DNS，即使配置有误。
如果 DNS 配置有误，尽到提醒义务即可；自行寻找可用的 DNS 并不是一个网络工具该做的。
现在，为了让 DNS 在没有 /etc/resolv.conf 文件的环境中正常工作，引入了太多不必要的复杂性（DNS 不可用时自动回落、维护国内/国外 DNS 列表等）；还破坏了其他用户的体验，所以是时候停止了。
There was a problem hiding this comment.
内置也还行吧。系统虽然复杂点，减少用户操作复杂度。不过可以简化下系统复杂度，达到更好效果
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Checks the Internet connection with a DNS lookup instead of an HTTP GET.
Motivation
DNS lookups are much cheaper than HTTP requests since we only need to check if the Internet is available. See https://stackoverflow.com/a/50058255 for more information.
Also inspired by:
Additional Notes
Renamed package
internaland functionWaitForNetworkConnectedtointernetandWaitto make the names more concise.Also renamed function
NewDialerResolvertoSetDNSfor the same reason.The use of
net.SplitHostPortinstead ofstrings.Containsin the functionSetDNSis for use custom ports in IPv6 DNS. See: