fix(web): logging if no domain is entered #1038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, if IPv4/6 is enabled but there is no domain, nothing happens. In this case, we should throw an error.
|
When IPv4 and IPv6 domains are not filled in, only display logs instead of throwing exceptions |
WaterLemons2k
changed the title
WaterLemons2k
changed the title
jeessy2
reviewed
Mar 10, 2024
WaterLemons2k
changed the title
jeessy2
reviewed
Mar 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Logging when both IPv4 and IPv6 domains are not provided.
Fixes #1036 and other similar issues.
Motivation
Currently, if both IPv4 and IPv6 domains are not provided, nothing happens. In this case, we should log this.
Additional Notes
Bool
firstTimewas based on a config error, but the error was ignored. Fixed.