Add support for Dynadot. #1050
Merged
Add support for Dynadot. #1050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
有没有成功后的截图 |
|
jeessy2
approved these changes
Mar 22, 2024
jeessy2
reviewed
Mar 22, 2024
dns/dynadot.go
Outdated
Comment on lines
132
to
138
| if result.ErrorCode != -1 { | ||
| util.Log("更新域名解析 %s 成功! IP: %s", domain, ipAddr) | ||
| domain.UpdateStatus = config.UpdatedSuccess | ||
| } else { | ||
| util.Log("新增域名解析 %s 失败! 异常信息: %s", domain, strings.Join(result.Content, ",")) | ||
| domain.UpdateStatus = config.UpdatedFailed | ||
| } |
There was a problem hiding this comment.
不好意思，这里是我的检查不到位，都使用更新就好
jeessy2
approved these changes
Mar 22, 2024
jeessy2
reviewed
Mar 22, 2024
Comment on lines
+120
to
+121
| var result DynadotResp | ||
| err := dynadot.request(params, &result) |
There was a problem hiding this comment.
每次都要请求接口，所以IP没有变动也会请求接口，会导致收到webhook通知过多
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
增加对Dynadot域名的DDNS支持
Motivation
我们是Dynadot的开发团队，Dynadot是一家国外域名注册商，目前我们大约管理480w域名并且还在持续增长。近期我们需要一个DDNS的客户端并且能支持跨平台，DDNS-GO是一个非常好的选择，所以我们希望使用DDNS-GO作为我们目前的官方推荐客户端
Additional Notes
我在代码中拓展了Dynadot的配置选项，并对封装好的功能做了一些测试工作，包括（域名设置、中英文日志、错误状态日志打印），目前该功能在Dynadot还在我们的灰度测试中，但是测试工作已经基本完成，并且会在合并后发行新版的安装包后将该功能上线。