chore(dns): log only the root domain if not found in provider #1118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now, when we list a zone, the logs alone can't determine which parts of the domain are being used as a root domain. Therefore, if `publicsuffix` provides a wrong root domain, the domain won't be found in the DNS provider even if it exists. We can solve this by logging only the root domain, since only the root domain is used to list zones; users will also know what's causing it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Logging only the root domain if the domain is not found in the DNS provider.
Useful when
publicsuffixprovides a wrong root domain.Motivation
Additional Notes