feat: checkbox to disable Webhook #656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
得考虑以前用户升级上来，默认配置为false |
|
|
|
是不是搞复杂了。disabled不是更简单一点？ |
|
也可以不考虑增加开关，没有URL就是disable，拷贝到下面也没什么影响，这个功能用的也不多 |
既然都写好了，肯定支持了更好吧 不影响什么 @WaterLemons2k 建议直接通过 |
WaterLemons2k
changed the title
|
|
|
换成按钮，都不能一眼就看清到底是启用状态还是禁用状态。 |
The button is no longer used.
WaterLemons2k
changed the title
|
|
…addEventListener` Add a new function `isWebhookStatusDisable`.
|
|
WaterLemons2k
changed the title
怎么简单怎么来。 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add a checkbox for disabling Webhook.
Closes #655.
Motivation
#655
Additional Notes
formData.append()only accepts string. If a boolean is required, it needs to be parsed as JSON on the backend.