chore: clean up and bump node version

.github/workflows/ci.yaml

@@ -10,7 +10,7 @@ jobs:
       - uses: actions/checkout@v2
       - uses: actions/setup-node@v2.1.4
         with:
-          node-version: 14.15.0
+          node-version: 14.15.4
       - uses: actions/cache@v2
         with:
           path: ~/.npm

.node-version

@@ -1 +1 @@
-14.15.0
+14.15.4

package.json

@@ -1,6 +1,6 @@
 {
   "name": "streetmerchant",
-  "description": "🔮 For all your Nvidia needs",
+  "description": "The world's easiest, most powerful stock checker",
   "main": "src/index.ts",
   "scripts": {
     "all": "npm run build && npm run lint",

src/notification/desktop.ts

@@ -4,7 +4,7 @@ import {config} from '../config';
 import {join} from 'path';
 import notifier from 'node-notifier';
 
-const desktop = config.notifications.desktop;
+const {desktop} = config.notifications;
 
 export function sendDesktopNotification(link: Link, store: Store) {
 	if (desktop) {

src/notification/discord.ts

@@ -3,8 +3,7 @@ import Discord from 'discord.js';
 import {config} from '../config';
 import {logger} from '../logger';
 
-const discord = config.notifications.discord;
-const {notifyGroup, webhooks, notifyGroupSeries} = discord;
+const {notifyGroup, webhooks, notifyGroupSeries} = config.notifications.discord;
 
 function getIdAndToken(webhook: string) {
 	const match = /.*\/webhooks\/(\d+)\/(.+)/.exec(webhook);

src/notification/email.ts

@@ -4,7 +4,7 @@ import Mail from 'nodemailer/lib/mailer';
 import {config} from '../config';
 import nodemailer from 'nodemailer';
 
-const email = config.notifications.email;
+const {email} = config.notifications;
 
 const transportOptions: any = {};
 

src/notification/mqtt.ts

@@ -3,7 +3,7 @@ import MqttClient, {IClientOptions, IClientPublishOptions} from 'mqtt';
 import {Print, logger} from '../logger';
 import {config} from '../config';
 
-const mqtt = config.notifications.mqtt;
+const {mqtt} = config.notifications;
 let client: MqttClient.Client;
 
 if (mqtt.broker) {

src/notification/philips-hue.ts

@@ -3,18 +3,19 @@ import {config} from '../config';
 import {v3 as hueAPI} from 'node-hue-api';
 import {logger} from '../logger';
 
-const hue = config.notifications.philips_hue;
-const apiKey = hue.apiKey;
-const bridgeIp = hue.bridgeIp;
-const lightIds = hue.lightIds;
-const lightColor = hue.lightColor;
-const lightPattern = hue.lightPattern;
-const LightState = hueAPI.lightStates.LightState;
-const clientId = hue.clientId;
-const clientSecret = hue.clientSecret;
-const accessToken = hue.accessToken;
-const refreshToken = hue.refreshToken;
-const remoteApiUsername = hue.remoteApiUsername;
+const {LightState} = hueAPI.lightStates;
+const {
+	apiKey,
+	bridgeIp,
+	lightIds,
+	lightColor,
+	lightPattern,
+	clientId,
+	clientSecret,
+	accessToken,
+	refreshToken,
+	remoteApiUsername
+} = config.notifications.philips_hue;
 
 // Default Light State
 const lightState = new LightState()
@@ -81,7 +82,7 @@ const adjustLightsWithAPI = (hueBridge: Api) => {
 
 export function adjustPhilipsHueLights() {
 	// Check if the required variables have been set
-	if (hue.apiKey && hue.bridgeIp) {
+	if (apiKey && bridgeIp) {
 		logger.info('↗ adjusting Philips Hue lights over LAN');
 		(async () => {
 			logger.debug(
@@ -100,7 +101,7 @@ export function adjustPhilipsHueLights() {
 					}
 				);
 		})();
-	} else if (hue.apiKey && hue.clientId && hue.clientSecret) {
+	} else if (apiKey && clientId && clientSecret) {
 		logger.info('↗ adjusting Philips Hue lights over cloud');
 		(async () => {
 			logger.debug(
@@ -110,7 +111,7 @@ export function adjustPhilipsHueLights() {
 				clientId,
 				clientSecret
 			);
-			if (hue.accessToken && hue.refreshToken) {
+			if (accessToken && refreshToken) {
 				remoteBootstrap
 					.connectWithTokens(
 						accessToken,

src/notification/pushbullet.ts

@@ -3,7 +3,7 @@ import {Print, logger} from '../logger';
 import PushBullet from '@jef/pushbullet';
 import {config} from '../config';
 
-const pushbullet = config.notifications.pushbullet;
+const {pushbullet} = config.notifications;
 
 export function sendPushbulletNotification(link: Link, store: Store) {
 	if (pushbullet) {

src/notification/pushover.ts

@@ -3,7 +3,7 @@ import {Print, logger} from '../logger';
 import Push, {PushoverMessage} from 'pushover-notifications';
 import {config} from '../config';
 
-const pushover = config.notifications.pushover;
+const {pushover} = config.notifications;
 
 export function sendPushoverNotification(link: Link, store: Store) {
 	if (pushover.token && pushover.username) {

src/notification/slack.ts

@@ -3,21 +3,19 @@ import {Print, logger} from '../logger';
 import {WebClient} from '@slack/web-api';
 import {config} from '../config';
 
-const slack = config.notifications.slack;
-const channel = slack.channel.replace('#', '');
-const token = slack.token;
+const {channel, token} = config.notifications.slack;
 const web = new WebClient(token);
 
 export function sendSlackMessage(link: Link, store: Store) {
-	if (slack.channel && slack.token) {
+	if (channel && token) {
 		logger.debug('↗ sending slack message');
 
 		(async () => {
 			const givenUrl = link.cartUrl ? link.cartUrl : link.url;
 
 			try {
 				const result = await web.chat.postMessage({
-					channel,
+					channel: channel.replace('#', ''),
 					text: `${Print.inStock(link, store)}\n${givenUrl}`
 				});
 

src/notification/sms.ts

@@ -4,7 +4,7 @@ import Mail from 'nodemailer/lib/mailer';
 import {config} from '../config';
 import {transporter} from './email';
 
-const [email, phone] = [config.notifications.email, config.notifications.phone];
+const {email, phone} = config.notifications;
 
 if (phone.number.length > 0 && (!email.username || !email.password)) {
 	logger.warn(

src/notification/telegram.ts

@@ -3,7 +3,7 @@ import {Print, logger} from '../logger';
 import {TelegramClient} from 'messaging-api-telegram';
 import {config} from '../config';
 
-const telegram = config.notifications.telegram;
+const {telegram} = config.notifications;
 
 const client = new TelegramClient({
 	accessToken: telegram.accessToken

src/notification/twilio.ts

@@ -3,7 +3,7 @@ import {Print, logger} from '../logger';
 import {Twilio} from 'twilio';
 import {config} from '../config';
 
-const twilio = config.notifications.twilio;
+const {twilio} = config.notifications;
 let client: Twilio;
 
 if (twilio.accountSid && twilio.authToken) {

src/notification/twitch.ts

@@ -5,7 +5,7 @@ import {existsSync, promises, readFileSync} from 'fs';
 import {ChatClient} from 'twitch-chat-client';
 import {config} from '../config';
 
-const twitch = config.notifications.twitch;
+const {twitch} = config.notifications;
 
 const messages: string[] = [];
 let alreadySaying = false;

src/notification/twitter.ts

@@ -3,7 +3,7 @@ import {Print, logger} from '../logger';
 import Twitter from 'twitter';
 import {config} from '../config';
 
-const twitter = config.notifications.twitter;
+const {twitter} = config.notifications;
 
 const client = new Twitter({
 	access_token_key: twitter.accessTokenKey,

src/store/model/helpers/backoff.ts

@@ -21,7 +21,7 @@ export async function processBackoffDelay(
 	 * the page renders fine and its content is accessible.
 	 */
 
-	let backoffStatusCodes = store.backoffStatusCodes;
+	let {backoffStatusCodes} = store;
 
 	if (!backoffStatusCodes) {
 		backoffStatusCodes = [403];

src/store/model/index.ts

@@ -366,15 +366,15 @@ export function updateStores() {
 updateStores();
 
 export function getAllBrands() {
-	return Array.from(brands);
+	return [...brands];
 }
 
 export function getAllSeries() {
-	return Array.from(series);
+	return [...series];
 }
 
 export function getAllModels() {
-	return Array.from(models);
+	return [...models];
 }
 
 export function getStores() {

src/web/index.ts

@@ -120,7 +120,7 @@ function handleAPI(
 			sendConfig(response);
 			return;
 		case 'stores':
-			sendJSON(response, Array.from(storeList.keys()));
+			sendJSON(response, [...storeList.keys()]);
 			return;
 		case 'brands':
 			sendJSON(response, getAllBrands());