Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(store): add 3060ti to newegg-ca, canadacomputer, memoryexpress #1172

Merged
merged 11 commits into from
Dec 4, 2020
Merged

feat(store): add 3060ti to newegg-ca, canadacomputer, memoryexpress #1172

merged 11 commits into from
Dec 4, 2020

Conversation

desigi
Copy link
Contributor

@desigi desigi commented Dec 4, 2020

Description

  • Added the 3060ti to newegg-ca.ts, canandacomputers.ts, and memoryexpress.
  • Added 4 new 3060ti models to store.ts.

Testing

Currently running this with 3060ti being checked.

@desigi desigi requested a review from jef as a code owner December 4, 2020 21:28
jef
jef requested changes Dec 4, 2020
View reviewed changes
Copy link
Owner

@jef jef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple little changes and I think we'll be good to go!

src/store/model/store.ts Outdated Show resolved Hide resolved
src/store/model/newegg-ca.ts Outdated Show resolved Hide resolved
desigi and others added 2 commits December 4, 2020 17:17
@desigi @jef
Update src/store/model/store.ts
c71bb56 
Co-authored-by: Jef LeCompte <jeffreylec@gmail.com>
@desigi @jef
Update src/store/model/newegg-ca.ts
896fe91 
Co-authored-by: Jef LeCompte <jeffreylec@gmail.com>
jef
jef approved these changes Dec 4, 2020
View reviewed changes
Copy link
Owner

@jef jef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thank you very much for the help!

@jef jef changed the title feat(store): Add 3060ti to newegg-ca, canadacomputer, memoryexpress feat(store): add 3060ti to newegg-ca, canadacomputer, memoryexpress Dec 4, 2020
@jef jef merged commit 09f0236 into jef:main Dec 4, 2020
@github-actions github-actions bot mentioned this pull request Oct 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jef jef jef approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@desigi @jef