Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(store): filter amazon third party vendors #126

Merged
merged 2 commits into from
Sep 20, 2020
Merged

chore(store): filter amazon third party vendors #126

merged 2 commits into from
Sep 20, 2020

Conversation

jef
Copy link
Owner

@jef jef commented Sep 20, 2020

Description

  • Filters third party vendors from Amazon and getting outrageous pricing
  • Change Store objects properties for ordering

@jef
chore(store): filter amazon third party vendors
d863b93 
Signed-off-by: Jef LeCompte <jeffreylec@gmail.com>
@jef jef self-assigned this Sep 20, 2020
admon84
admon84 previously approved these changes Sep 20, 2020
View reviewed changes
Copy link
Contributor

@admon84 admon84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reordering some of the change I made. I'll give more attention to ordering in future contributions. The changes look good to me

Doridian
Doridian previously approved these changes Sep 20, 2020
View reviewed changes
Copy link
Collaborator

@Doridian Doridian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The refactor will likely clash with the hotfix #124 so maybe incorporate it right into this PR? Or do it right after. Unsure.

@jef
Copy link
Owner Author

jef commented Sep 20, 2020

Let's merge #124 first!

@jef jef dismissed stale reviews from Doridian and admon84 via 674f14f September 20, 2020 20:20
@jef
Copy link
Owner Author

jef commented Sep 20, 2020

I'll give more attention to ordering in future contributions. The changes look good to me

I'm trying to find an option within xo or prettier to do this for us.

@jef jef requested a review from Doridian September 20, 2020 20:29
@jef jef merged commit 07b2da4 into main Sep 20, 2020
@jef jef deleted the jef/amazon-third-party branch September 20, 2020 20:45
@jef jef mentioned this pull request Sep 21, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Doridian Doridian Doridian approved these changes

@admon84 admon84 admon84 left review comments

Assignees

@jef jef

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jef @Doridian @admon84