Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(store): add darkhero motherboard to asus and microcenter #1336

Merged
merged 3 commits into from
Dec 11, 2020
Merged

feat(store): add darkhero motherboard to asus and microcenter #1336

merged 3 commits into from
Dec 11, 2020

Conversation

moodswung
Copy link
Contributor

@moodswung moodswung commented Dec 11, 2020 •
edited

This adds support for the Asus Dark Hero motherboard. It is currently scanning the Asus Store, Microcenter and NewEgg.

@moodswung moodswung requested a review from jef as a code owner December 11, 2020 04:41
@moodswung moodswung changed the title add darkhero motherboard to asus and microcenter feat: add darkhero motherboard to asus and microcenter Dec 11, 2020
@moodswung moodswung changed the title feat: add darkhero motherboard to asus and microcenter feat(lookup): add darkhero motherboard to asus and microcenter Dec 11, 2020
jef
jef reviewed Dec 11, 2020
View reviewed changes
Copy link
Owner

@jef jef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

I have two suggestions:

  1. I think you'll want to use the model crosshair viii.
  2. Do you mind updating the docs? You'll find it in docs/filter/reference.md

Other than that, looks great!

@moodswung
change model to 'crosshair viii'
4853a2e 
update documentation files
jef
jef approved these changes Dec 11, 2020
View reviewed changes
Copy link
Owner

@jef jef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you very much :shipit:

@jef jef changed the title feat(lookup): add darkhero motherboard to asus and microcenter feat(store): add darkhero motherboard to asus and microcenter Dec 11, 2020
@jef jef merged commit 29175c7 into jef:main Dec 11, 2020
ven0ms99 pushed a commit to ven0ms99/streetmerchant that referenced this pull request Dec 11, 2020
@moodswung @FabianRohr
feat(store): add darkhero motherboard to asus and microcenter (jef#1336)
733c33d
@github-actions github-actions bot mentioned this pull request Oct 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jef jef jef approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@moodswung @jef