fix(store): update missing/mislabeled cards for Canadian retailers #1574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anthonytam
changed the title
…d notInStock attribute
jef
approved these changes
Jan 3, 2021
jef
changed the title
erwinc1
pushed a commit
to erwinc1/streetmerchant
that referenced
this pull request
Mar 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1513 and fixes #1371
I noticed multiple different CPUs/GPUs were not present in several different Canadian retailers, I went through the list of them and added the missing cards and removed some dead links (which caused the issue in #1513). While doing so, I noticed many Twin Edge, TUF, Aourus Master and Eagle cards were mis-categorized or were missing the oc suffix.
amazon-ca wasn't updated as a part of this, finding cards is a bit of a mess right now as amazon tends to hide products with no stock in strange ways.
Testing
I've been running this branch for ~24 hours now and haven't identified any issues. The new cards are being searched and old cards are now searched under the correct category (the issue in #1371)