-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: bring back ascii banner, but make it configurable #703
Conversation
Haha, you miss it? |
I don't miss it anymore...BECAUSE I PUT IT BACK :) |
Let me think about it 😆 I think we can have this go in, but maybe we can talk about the ASCII art. This one in particular is pretty big. What do you think? |
Yeah, this particular font is a bit big...could easily go with a font like the original had: I would fix the spacing around the hyphen by hand though. |
I think I prefer hyphen-less, no space. I thought about using 'Bloody' then I went to the full-width text. |
If we go with Bloody I am adding the option to pick the font color! |
didn't realize I could run the node linter from npm...I feel dumb...
Haha, I love it. Thanks for the back and forth on this. I didn't want to dictate what font we choose here, but here we are.
Talking about customization... https://www.npmjs.com/package/figlet this doesn't have any dependencies. Could be fun to bring this in. What do you think? |
You read my mind. Was just looking at a few ASCII art renderers. Will probably play with it separate from this over the weekend. |
That being said, I suppose we can pull this in and you can make another PR if you'd like. What would you like to do? |
I think merge this and then we continue a larger talk about the state of the frontend else where. |
Description
Fixes the removal of the amazing ascii art with project name change.
Testing
Run it, toggle the env var ASCII_BANNER to see the different options.