Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bring back ascii banner, but make it configurable #703

Merged
merged 7 commits into from
Nov 6, 2020

Conversation

njgreb
Copy link
Contributor

@njgreb njgreb commented Nov 6, 2020

Description

Fixes the removal of the amazing ascii art with project name change.

Testing

Run it, toggle the env var ASCII_BANNER to see the different options.

@njgreb njgreb requested a review from jef as a code owner November 6, 2020 14:34
@jef
Copy link
Owner

jef commented Nov 6, 2020

Haha, you miss it?

@njgreb
Copy link
Contributor Author

njgreb commented Nov 6, 2020

I don't miss it anymore...BECAUSE I PUT IT BACK :)

@jef
Copy link
Owner

jef commented Nov 6, 2020

Let me think about it 😆 I think we can have this go in, but maybe we can talk about the ASCII art. This one in particular is pretty big. What do you think?

@njgreb
Copy link
Contributor Author

njgreb commented Nov 6, 2020

Yeah, this particular font is a bit big...could easily go with a font like the original had:
https://patorjk.com/software/taag/#p=display&f=Big%20Money-se&t=STREET-%20MERCHANT

I would fix the spacing around the hyphen by hand though.

@jef
Copy link
Owner

jef commented Nov 6, 2020

I think I prefer hyphen-less, no space. I thought about using 'Bloody' then I went to the full-width text.

@njgreb
Copy link
Contributor Author

njgreb commented Nov 6, 2020

If we go with Bloody I am adding the option to pick the font color!

Nathan Grebowiec added 4 commits November 6, 2020 09:16
@jef
Copy link
Owner

jef commented Nov 6, 2020

Haha, I love it. Thanks for the back and forth on this. I didn't want to dictate what font we choose here, but here we are.

If we go with Bloody I am adding the option to pick the font color!

Talking about customization... https://www.npmjs.com/package/figlet this doesn't have any dependencies. Could be fun to bring this in. What do you think?

@njgreb
Copy link
Contributor Author

njgreb commented Nov 6, 2020

You read my mind. Was just looking at a few ASCII art renderers. Will probably play with it separate from this over the weekend.

@jef
Copy link
Owner

jef commented Nov 6, 2020

That being said, I suppose we can pull this in and you can make another PR if you'd like. What would you like to do?

@njgreb
Copy link
Contributor Author

njgreb commented Nov 6, 2020

I think merge this and then we continue a larger talk about the state of the frontend else where.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants