-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
C++ Fix for #47 #49
C++ Fix for #47 #49
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added tags to the colon and the commas. Other than that my changes were basically just moving code around. Great job 👍
You shouldn't need the complicated Regex on https://github.com/jeff-hykin/cpp-textmate-grammar/blob/b1b034011874d96e10ecc9a42a87771fbe800748/generate.rb#L891 patterns are matched in order so |
The reason I did the abstraction is because your pattern matching was better, and it could be used in 2nd place. I appreciate you looking over the changes though 👍 |
Ah, okay. You might still want to fix the regex tagging the space before the inherited class, however. |
Good call, I missed that. Next time I'll post my changes for review Haha. |
This provides a C++ fix for #47.
Additionally, this improves highlighting of inherited base classes. Previously only 1 base class per access specifier was allowed. This PR extends that to any number of base classes.
This does not fix the same issue in the C grammar.