Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add consteval keyword highlighted. (fixes #573) #574

Merged
merged 1 commit into from
Oct 14, 2021

Conversation

soroshsabz
Copy link
Contributor

ITNOA

I try to add consteval keyword highlight. this PR is resolved #573

- comment.line.double-slash
- source: constexpr
scopesBegin:
- meta.function.definition
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why constexpr has scopesBegin, but cosnteval does not have scopesBegin?

@matter123

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeff-hykin can you explain to me, why this happen?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know.

meta.function.definiton Just means the start of a function. It should stop at the }.

Then it should start again with consteval

But it never stops.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thinking same, but as you can see with constexpr, meta.function.definito is begin but in consteval I could not found meta.function.definito in source of consteval

I think it is like bug, because I think constexpr and consteval is behave same and fully similar in function declaration.

@soroshsabz
Copy link
Contributor Author

@matter123 @jeff-hykin Please review it

thanks :)

@jeff-hykin jeff-hykin merged commit 89a5c27 into jeff-hykin:master Oct 14, 2021
@jeff-hykin
Copy link
Owner

looks good! Next time I have the repo open I'll publish it. And just post a bump message if it's been a week or two and still isn't in the Extension

@soroshsabz
Copy link
Contributor Author

related to #396

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

C++20 consteval keyword is not highlighted
2 participants