Cpp/fix/#407 #595
Merged
Cpp/fix/#407 #595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the fix! Sorry it took so long to merge. Its now pushed on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is my proposal for fixing issue #407 (see also duplicate issue #496 and related issue #587).
I introduced four additional TextMate scopes, namely
keyword.other.[default|delete].[destructor|function]since any special member function can be defaulted (not only constructors) and any function can be deleted. I did not remove the existing scopeskeyword.other.[default|delete].constructorfor destructors to ensure backward compatibility.