Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Events should be namespaced #86

Open
mattflaschen opened this issue Jan 18, 2013 · 0 comments
Open

Events should be namespaced #86

mattflaschen opened this issue Jan 18, 2013 · 0 comments

Comments

@mattflaschen
Copy link
Contributor

There is a call to unbind that unbinds all keydown handlers on document, not just those added by guiders.

The easiest solution for this is to use jQuery's namespaced events. Strictly, it is only needed when you're doing an unbind. But for consistency (and so unbinds can be added easily later), it's better to do it everywhere.

I will try to do a pull request for this shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant