Support julia 0.5 #135
Merged
Support julia 0.5 #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -464,7 +464,7 @@ function limit_to_object_data( | |||
| # Get the sources that overlap with this object. | |||
| relevant_sources = Int[] | |||
| for b = 1:length(blob), tile_sources in mp.tile_sources[b] | |||
| if s_original in tile_sources > 0 | |||
There was a problem hiding this comment.
We probably didn't mean to compare a boolean to an int before, but for whatever reason 0.4 doesn't complain, while 0.5 stops.
jrevels
pushed a commit
to jrevels/Celeste.jl
that referenced
this pull request
Nov 3, 2016
…htly Support julia 0.5 Former-commit-id: c4ceb93
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR turns on travis testing for Julia nightly, and makes the tests pass. It isn't always pretty:
runtests.jlchecks outOptim.jlmaster andDataFrames.jlmasterGaussianProcesses.jland fixed just enough of it.runtests.jlclones the fork.JLD.jldoesn't work yet, though it may soon: Broken function support in julia-0.5 (all functions are generic) JuliaIO/JLD.jl#57 This doesn't stop the tests because the JLD stuff is all in bin.Still, I'd say the PR closes #118