Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When tcp service's host is unreachable, wait-on should exit with status code 0 in reverse mode #31

Closed
TKasperczyk opened this issue Oct 30, 2018 · 0 comments

Comments

@TKasperczyk
Copy link
Contributor

Let's assume that the following IP address is unreachable: 1.2.3.4. When you execute wait-on tcp:1.2.3.4:554 -r, the command should exit after a short time with code 0 because the service is not available. Unfortunately, it doesn't exit at all. I think it's because you don't have a timeout event handler in the createTcp$ function. I propose to add an additional option called "tcpTimeout" and the timeout event handler which would mirror the behaviour of the error handler.

@TKasperczyk TKasperczyk changed the title When tcp service's host is unreachable, wait-on should exit with status code 0 When tcp service's host is unreachable, wait-on should exit with status code 0 in reverse mode Oct 30, 2018
jeffbski added a commit that referenced this issue Nov 6, 2018
Adds a tcp timeout. Fixes #31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant