Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review the update method #25

Closed
Tuizi opened this issue May 5, 2016 · 2 comments
Closed

Review the update method #25

Tuizi opened this issue May 5, 2016 · 2 comments
Assignees
@Tuizi
Labels
bug
Milestone
Version 1.1.2

Comments

@Tuizi
Copy link
Collaborator

Tuizi commented May 5, 2016 •
edited
Loading

Update function seems to have a problem with long text... (Issue present in 1.1.0)
https://plnkr.co/edit/jVSCVD1yqhzGNWVZlFo1?

(@skaor report)
@Tuizi Tuizi self-assigned this May 5, 2016
@Tuizi Tuizi added the bug label May 5, 2016
@Tuizi
Copy link
Collaborator Author

Tuizi commented May 24, 2016

@skaor. I Cannot reproduce.

  1. Initial text is some long text
  2. Config to truncate on 1 line
  3. Then update the text by calling the update method and passing the new text
  4. Call expand

Result: Text is updated with the new text as expected

Did I miss something?

@Tuizi Tuizi added this to the Version 1.1.2 milestone May 24, 2016
@Tuizi
Copy link
Collaborator Author

Tuizi commented May 27, 2016

Ok the bug we are looking for is reproducible here:
https://plnkr.co/edit/tCobs2AVpUmlEeW5OYDC?p=preview

Tuizi added a commit that referenced this issue Jun 9, 2016
@Tuizi
Fix #25
36570ef
@Tuizi Tuizi closed this as completed Jun 16, 2016
@Tuizi Tuizi mentioned this issue Jun 21, 2016
Merged
Tuizi added a commit that referenced this issue Jun 22, 2016
@Tuizi
Close bugs for milestone 1.1.2 (#29)
ebf6aa5 
Fix issues #8, #11, #25. #26 + bump version to 1.1.2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tuizi Tuizi

Labels
bug
Projects
None yet
Milestone
Version 1.1.2
Development

No branches or pull requests
1 participant
@Tuizi