Adding type hints to @Timed ast transformation. #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without the type hints, @timed cannot be used in Grails 2.3 apps with services that has the new grails @transactional annotation (i.e. not the Spring @transactional annotation). This is because @transactional changes the AST to have @CompileStatic, which in turn breaks with the dynamic declarations this commit fixes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without the type hints, @timed cannot be used in Grails 2.3 apps with
services that has the new grails @transactional annotation (i.e. not the
Spring @transactional annotation). This is because @transactional
changes the AST to have @CompileStatic, which in turn breaks with the
dynamic declarations this commit fixes.