Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible recurrence relation error in Subset Sum: Ch. 3 section 8 pg. 114 #10

Closed
mousseinov opened this issue Dec 31, 2018 · 3 comments
Closed
Labels
cosmetic Cosmetic issue (spelling, grammar, etc.) error Technical error requiring correction fixed Fixed in Jeff's working copy. (Issue remains open until next revision posted to github.) multiple Multiple issues in one report

Comments

@mousseinov
Copy link

mousseinov commented Dec 31, 2018

page 114, section 3.8: In the pseudo code recurrence relation at the bottom of the page for subset sum modified for avoiding the case when t is negative, it says SS(i, t) = SS(i + 1, t) when t > X[i] in the third case, for that case wouldn't it be valid when t < X[i] rather than t > X[i], as that would make the t that is being passed in negative when doing SS(i, t - X[i]) which would automatically yield a False.

@echuber2
Copy link

The typo is in the recurrence relation rather than the pseudocode listing, but I think you're right.

There's also a typo in footnote 17 at the bottom of p. 115: "is not necessary bounded" should say "necessarily."

@mousseinov
Copy link
Author

mousseinov commented Dec 31, 2018

Sorry, yeah I meant to say the recurrence relation, not the pseudo code. Thank you!

@mousseinov mousseinov changed the title Possible pseudocode error in Subset Sum: Ch. 3 section 8 pg. 114 Possible ~~pseudocode~~ recurrence relation error in Subset Sum: Ch. 3 section 8 pg. 114 Dec 31, 2018
@mousseinov mousseinov changed the title Possible ~~pseudocode~~ recurrence relation error in Subset Sum: Ch. 3 section 8 pg. 114 Possible ~pseudocode~ recurrence relation error in Subset Sum: Ch. 3 section 8 pg. 114 Dec 31, 2018
@mousseinov mousseinov changed the title Possible ~pseudocode~ recurrence relation error in Subset Sum: Ch. 3 section 8 pg. 114 Possible recurrence relation error in Subset Sum: Ch. 3 section 8 pg. 114 Dec 31, 2018
@jeffgerickson
Copy link
Owner

Yes, "if t > X[i]" should be "if t < X[i]".

@jeffgerickson jeffgerickson added cosmetic Cosmetic issue (spelling, grammar, etc.) error Technical error requiring correction Medium priority multiple Multiple issues in one report and removed Medium priority labels Jan 3, 2019
@jeffgerickson jeffgerickson added the fixed Fixed in Jeff's working copy. (Issue remains open until next revision posted to github.) label Mar 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cosmetic Cosmetic issue (spelling, grammar, etc.) error Technical error requiring correction fixed Fixed in Jeff's working copy. (Issue remains open until next revision posted to github.) multiple Multiple issues in one report
Projects
None yet
Development

No branches or pull requests

3 participants