BUG: fix ZS collinearity labeling with endogenous shares

jeffgortmaker · Jan 29, 2022 · 5b59b8d · 5b59b8d
1 parent 46ad949
commit 5b59b8d
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/pyblp/economies/economy.py b/pyblp/economies/economy.py
@@ -176,7 +176,7 @@ def _detect_collinearity(self, added_exogenous: bool) -> None:
             'X2': [str(f) for f in self._X2_formulations],
             'X3': [str(f) for f in self._X3_formulations],
             'ZD': [str(f) for f in self._X1_formulations if 'prices' not in f.names] if added_exogenous else [],
-            'ZS': [str(f) for f in self._X3_formulations] if added_exogenous else [],
+            'ZS': [str(f) for f in self._X3_formulations if 'shares' not in f.names] if added_exogenous else [],
         }
         matrix_labels.update({
             'ZD': [f'demand_instruments{i}' for i in range(self.MD - len(matrix_labels['ZD']))] + matrix_labels['ZD'],