Email verification controller #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
EzimetYusup
commented
Oct 17, 2022
EzimetYusup
commented
- updated config to have Path to email verification Controller component.
- Moved Authenticate middleware to the EmailVerificationController
Saifallak
reviewed
Oct 19, 2022
| @@ -26,10 +26,10 @@ | |||
| ->name("verification.notice"); | |||
|
|
|||
| Route::get("email/verify/{id}/{hash}", [ | |||
| EmailVerificationController::class, | |||
| config('filament-breezy.email_verification_controller_path'), | |||
There was a problem hiding this comment.
isn't this a breaking change to use this without default value?
as other (already running) apps that don't have this config will receive null?
or am i wrong?
There was a problem hiding this comment.
TBH, I didn't test it, just asking, how laravel handling this? does it merge package config with user config?
There was a problem hiding this comment.
It is. I am reviewing now. Thank you!
There was a problem hiding this comment.
anytime ^^, thanks for your hard work.
ashleyhood
reviewed
Oct 20, 2022
| @@ -10,6 +10,11 @@ | |||
|
|
|||
| class EmailVerificationController extends Controller | |||
| { | |||
| public function __construct() | |||
| { | |||
| $this->middleware([Authenticate::class]); | |||
There was a problem hiding this comment.
This is not namespaced correctly and breaks as it is looking for JeffGreco13\FilamentBreezy\Http\Controllers\Authenticate class.
Should be Filament\Http\Middleware\Authenticate::class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.