Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Match parameter types of aliasTo from container.resolve #342

Merged
merged 2 commits into from
Oct 12, 2023
Merged

Match parameter types of aliasTo from container.resolve #342

merged 2 commits into from
Oct 12, 2023

Conversation

zb-sj
Copy link
Contributor

@zb-sj zb-sj commented Oct 12, 2023 •
edited
Loading

Allow aliasTo to handle Symbol.

@zb-sj
fix: aliasTo should match container.resolve
8c902de 
where symbol can be used for name
@zb-sj zb-sj changed the title fix: aliasTo should match container.resolve Match parameter types of aliasTo from container.resolve Oct 12, 2023
@coveralls
Copy link

coveralls commented Oct 12, 2023 •
edited
Loading

Coverage Status

coverage: 100.0%. remained the same when pulling cb55556 on zb-sj:fix/aliasTo into 983935b on jeffijoe:master.

@jeffijoe
Copy link
Owner

Thanks for the PR!

I don't think we should allow passing resolve options just yet. How about simply updating the parameter to string | symbol?

@zb-sj
Copy link
Contributor Author

zb-sj commented Oct 12, 2023

Thanks for the PR!

I don't think we should allow passing resolve options just yet. How about simply updating the parameter to string | symbol?

Wow such a fast response!
I doubted about the options as well. 😄
Would this change suffice?

@jeffijoe
Copy link
Owner

Yes that works too!

@jeffijoe jeffijoe merged commit 924ce76 into jeffijoe:master Oct 12, 2023
5 checks passed
@jeffijoe
Copy link
Owner

I've released v9.0.0 with this change, thanks!

@zb-sj zb-sj deleted the fix/aliasTo branch October 13, 2023 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zb-sj @coveralls @jeffijoe