Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added optional params to assert methods #6

Merged
merged 1 commit into from
May 22, 2019

Conversation

johannesschobel
Copy link
Contributor

As discussed in #4 , this PR adds the optional params to the assert methods..

@coveralls
Copy link

coveralls commented May 22, 2019

Coverage Status

Coverage remained the same at 100.0% when pulling d8c5437 on johannesschobel:assert into 5a96bcf on jeffijoe:master.

@jeffijoe
Copy link
Owner

This looks great! Thank you!

@jeffijoe
Copy link
Owner

Before I merge, I need you to change the commit message to be feat: add optional assert params — that way the automated release pipeline knows it's a feature and so will bump the minor version. 😄

You can do that with git commit --amend, then git push -f.

@johannesschobel
Copy link
Contributor Author

using git on console is some weird black magic stuff 😨
but i think it worked?! *fingers crossed*

@jeffijoe
Copy link
Owner

There ya go 😄

@jeffijoe jeffijoe merged commit 3870871 into jeffijoe:master May 22, 2019
@johannesschobel
Copy link
Contributor Author

thanks man!

@jeffijoe
Copy link
Owner

🎉 This PR is included in version 2.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@jeffijoe
Copy link
Owner

@johannesschobel and that is the automated release stuff I was talking about. I just merged your PR to master and it automatically got released with a changelog entry. 😄

@johannesschobel
Copy link
Contributor Author

yeah, i read about this semantic-release stuff and things.. well, i think its kind of nice 👍 haha.. need to dig a bit deeper into this! Thanks man!

@johannesschobel johannesschobel deleted the assert branch May 22, 2019 13:02
@jeffijoe
Copy link
Owner

Thanks for the PR!

jeffijoe added a commit that referenced this pull request May 27, 2019
Fixes a type regression introduced in #6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants