Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to shell script instead of postinstall #66

Merged
merged 1 commit into from
Feb 14, 2021
Merged

Switch to shell script instead of postinstall #66

merged 1 commit into from
Feb 14, 2021

Conversation

karlhorky
Copy link
Contributor

npm does not run postinstall on every package install (as @mike-clark-8192 mentioned in #65 (comment)).

This switches to a bash script as an alternative.


Thinking about this more, it would be even nicer if typesync could take a package name as an argument:

typesync install <pkg name>

or just:

typesync <pkg name>

and then it would handle the installation, like typac does. Then there would be no need for a shell script.

npm does not run postinstall on every package install
@coveralls
Copy link
Collaborator

Coverage Status

Coverage remained the same at 100.0% when pulling 0c25a8e on karlhorky:patch-1 into a623e61 on jeffijoe:master.

@jeffijoe jeffijoe merged commit 4a012b7 into jeffijoe:master Feb 14, 2021
@karlhorky karlhorky deleted the patch-1 branch February 14, 2021 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants