pip install instructions don't work #72

Closed
lurch opened this Issue May 2, 2016 · 4 comments

Comments

Projects
None yet
5 participants
@lurch

lurch commented May 2, 2016

$ pip install git+https://github.com/jeffkaufman/icdiff.git
Collecting git+https://github.com/jeffkaufman/icdiff.git
  Cloning https://github.com/jeffkaufman/icdiff.git to /tmp/pip-430nkex7-build
    Complete output from command python setup.py egg_info:
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/tmp/pip-430nkex7-build/setup.py", line 3, in <module>
        from icdiff import __version__
    ImportError: No module named 'icdiff'

    ----------------------------------------
Command "python setup.py egg_info" failed with error code 1 in /tmp/pip-430nkex7-build/

I wonder if this might be because you forgot to rename icdiff to icdiff.py when merging #69 ?
46d5a72

@xuedong09

This comment has been minimized.

Show comment
Hide comment
@xuedong09

xuedong09 May 3, 2016

+1
Fix ImportError: No module named icdiff #73

This pull request fix my problem

+1
Fix ImportError: No module named icdiff #73

This pull request fix my problem

@satta

This comment has been minimized.

Show comment
Hide comment
@satta

satta May 3, 2016

Contributor

I'd suggest not to rename the main command to icdiff.py without also providing at least a wrapper script without the extension. The best solution here would be IMHO a proper separation between the module code and the tool itself. The module would have the .py extension and live in the proper Python library paths, and the tool without the extension would just use the module and live in /usr/bin.

Contributor

satta commented May 3, 2016

I'd suggest not to rename the main command to icdiff.py without also providing at least a wrapper script without the extension. The best solution here would be IMHO a proper separation between the module code and the tool itself. The module would have the .py extension and live in the proper Python library paths, and the tool without the extension would just use the module and live in /usr/bin.

@lodagro

This comment has been minimized.

Show comment
Hide comment
@lodagro

lodagro Jan 23, 2017

Just tried to install icdiff using the above pip command and got the same error.

Collecting git+https://github.com/jeffkaufman/icdiff.git
  Cloning https://github.com/jeffkaufman/icdiff.git to /tmp/pip-BAZU13-build
    Complete output from command python setup.py egg_info:
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/tmp/pip-BAZU13-build/setup.py", line 3, in <module>
        from icdiff import __version__
    ImportError: No module named icdiff

As workaround i did

cd /tmp/pip-BAZU13-build
ln -s icdiff icdiff.py
python setup.py install

Install went fine, both module and binary available (which is what i want).

lodagro commented Jan 23, 2017

Just tried to install icdiff using the above pip command and got the same error.

Collecting git+https://github.com/jeffkaufman/icdiff.git
  Cloning https://github.com/jeffkaufman/icdiff.git to /tmp/pip-BAZU13-build
    Complete output from command python setup.py egg_info:
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/tmp/pip-BAZU13-build/setup.py", line 3, in <module>
        from icdiff import __version__
    ImportError: No module named icdiff

As workaround i did

cd /tmp/pip-BAZU13-build
ln -s icdiff icdiff.py
python setup.py install

Install went fine, both module and binary available (which is what i want).

@jeffkaufman

This comment has been minimized.

Show comment
Hide comment
@jeffkaufman

jeffkaufman Dec 21, 2017

Owner

This was resolved several months ago; I think it's all set now.

Owner

jeffkaufman commented Dec 21, 2017

This was resolved several months ago; I think it's all set now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment