Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pip install instructions don't work #72

Closed
lurch opened this issue May 2, 2016 · 4 comments
Closed

pip install instructions don't work #72

lurch opened this issue May 2, 2016 · 4 comments

Comments

@lurch
Copy link

lurch commented May 2, 2016

$ pip install git+https://github.com/jeffkaufman/icdiff.git
Collecting git+https://github.com/jeffkaufman/icdiff.git
  Cloning https://github.com/jeffkaufman/icdiff.git to /tmp/pip-430nkex7-build
    Complete output from command python setup.py egg_info:
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/tmp/pip-430nkex7-build/setup.py", line 3, in <module>
        from icdiff import __version__
    ImportError: No module named 'icdiff'

    ----------------------------------------
Command "python setup.py egg_info" failed with error code 1 in /tmp/pip-430nkex7-build/

I wonder if this might be because you forgot to rename icdiff to icdiff.py when merging #69 ?
46d5a72

@xuedong09
Copy link

+1
Fix ImportError: No module named icdiff #73

This pull request fix my problem

@satta
Copy link
Contributor

satta commented May 3, 2016

I'd suggest not to rename the main command to icdiff.py without also providing at least a wrapper script without the extension. The best solution here would be IMHO a proper separation between the module code and the tool itself. The module would have the .py extension and live in the proper Python library paths, and the tool without the extension would just use the module and live in /usr/bin.

@lodagro
Copy link

lodagro commented Jan 23, 2017

Just tried to install icdiff using the above pip command and got the same error.

Collecting git+https://github.com/jeffkaufman/icdiff.git
  Cloning https://github.com/jeffkaufman/icdiff.git to /tmp/pip-BAZU13-build
    Complete output from command python setup.py egg_info:
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/tmp/pip-BAZU13-build/setup.py", line 3, in <module>
        from icdiff import __version__
    ImportError: No module named icdiff

As workaround i did

cd /tmp/pip-BAZU13-build
ln -s icdiff icdiff.py
python setup.py install

Install went fine, both module and binary available (which is what i want).

@jeffkaufman
Copy link
Owner

This was resolved several months ago; I think it's all set now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants