github api proxy: use for 'next' links #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now PRs #33 generally fail TravisCI because once they have enough reviews that GitHub's API starts paginating they switch from my authenticating proxy with 5000 requests per hour to GitHub's default of 60. Pagination works via the query string, so just apply the returned query string to our base url.
pavellishin
approved these changes
Jan 17, 2019
pavellishin
requested review from
sligocki,
jmitchell,
dchudz,
guoruibiao,
shaunagm,
TheJhyde,
tnelling and
vesche
tnelling
approved these changes
Jan 17, 2019
sligocki
approved these changes
Jan 17, 2019
shaunagm
approved these changes
Jan 17, 2019
|
We just need one more approval, please - @dchudz @TheJhyde @vesche @guoruibiao |
vesche
approved these changes
Jan 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now PRs like #33 generally fail TravisCI because once they have enough reviews that GitHub's API starts paginating they switch from my authenticating proxy with 5000 requests per hour to GitHub's default of 60. Pagination works via the query string, so just apply the returned query string to our base url.