Add missing dtors for pimpl pattern

Change-Id: I0c06793275de0bf96be5602e5c99ae9cf7ad2b14
jeffknupp · May 13, 2017 · d7b7c9c · d7b7c9c
1 parent a797ee3
commit d7b7c9c
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 0 deletions.
diff --git a/cpp/src/arrow/ipc/reader.cc b/cpp/src/arrow/ipc/reader.cc
@@ -273,6 +273,8 @@ RecordBatchStreamReader::RecordBatchStreamReader() {
   impl_.reset(new RecordBatchStreamReaderImpl());
 }
 
+RecordBatchStreamReader::~RecordBatchStreamReader() {}
+
 Status RecordBatchStreamReader::Open(const std::shared_ptr<io::InputStream>& stream,
     std::shared_ptr<RecordBatchStreamReader>* reader) {
   // Private ctor

diff --git a/cpp/src/arrow/ipc/reader.h b/cpp/src/arrow/ipc/reader.h
@@ -64,6 +64,8 @@ class ARROW_EXPORT RecordBatchReader {
 /// \brief Synchronous batch stream reader that reads from io::InputStream
 class ARROW_EXPORT RecordBatchStreamReader : public RecordBatchReader {
  public:
+  virtual ~RecordBatchStreamReader();
+
   /// Create batch reader from InputStream
   ///
   /// \param(in) stream an input stream instance

diff --git a/cpp/src/arrow/ipc/writer.cc b/cpp/src/arrow/ipc/writer.cc
@@ -730,6 +730,8 @@ RecordBatchStreamWriter::RecordBatchStreamWriter() {
   impl_.reset(new RecordBatchStreamWriterImpl());
 }
 
+RecordBatchStreamWriter::~RecordBatchStreamWriter() {}
+
 Status RecordBatchStreamWriter::WriteRecordBatch(
     const RecordBatch& batch, bool allow_64bit) {
   return impl_->WriteRecordBatch(batch, allow_64bit);

diff --git a/cpp/src/arrow/ipc/writer.h b/cpp/src/arrow/ipc/writer.h
@@ -75,6 +75,8 @@ class ARROW_EXPORT RecordBatchWriter {
 /// format
 class ARROW_EXPORT RecordBatchStreamWriter : public RecordBatchWriter {
  public:
+  virtual ~RecordBatchStreamWriter();
+
   /// Create a new writer from stream sink and schema. User is responsible for
   /// closing the actual OutputStream.
   ///