iOS Crash Issue resolved #95
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SidVoraDeveloper
commented
Jul 15, 2021
SidVoraDeveloper
commented
- Change dictionary type and validation for add outgoing params add
- Change dictionary type and validation for add outgoing params add
jeznag
reviewed
Jul 15, 2021
src/ios/TwilioVoicePlugin.m
Outdated
| @@ -161,11 +161,22 @@ - (void) initializeWithAccessToken:(CDVInvokedUrlCommand*)command { | |||
|
|
|||
| - (void) call:(CDVInvokedUrlCommand*)command { | |||
| if ([command.arguments count] > 0) { | |||
|
|
|||
jeznag
reviewed
Jul 15, 2021
src/ios/TwilioVoicePlugin.m
Outdated
| if (command.arguments[0] != [NSNull null]) { | ||
| self.accessToken = command.arguments[0]; | ||
| } | ||
| if ([command.arguments count] > 1) { | ||
| self.outgoingCallParams = command.arguments[1]; | ||
| if ( [allTrim( command.arguments[1] ) length] == 0 ) { | ||
| NSDictionary *inventory = @{ |
There was a problem hiding this comment.
this is to handle a string for the number rather than an object right?
Can you add a comment accordingly?
Also improve the variable name (perhaps callParams)
jeznag
reviewed
Jul 15, 2021
src/ios/TwilioVoicePlugin.m
Outdated
| NSDictionary *inventory = @{ | ||
| @"" : command.arguments[1] | ||
| }; | ||
| self.outgoingCallParams = inventory; //command.arguments[1]; |
jeznag
reviewed
Jul 15, 2021
| self.outgoingCallParams = inventory; //command.arguments[1]; | ||
|
|
||
| }else { | ||
| self.outgoingCallParams = [[NSMutableDictionary alloc] init]; |
There was a problem hiding this comment.
what is this case? You're creating a blank dictionary? It cannot be blank
jeznag
reviewed
Jul 15, 2021
| }; | ||
| self.outgoingCallParams = inventory; //command.arguments[1]; | ||
|
|
||
| }else { |
There was a problem hiding this comment.
inconsistent styling. Elsewhere there is a space on either space of else
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.