Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes in ActiveRecord integration #26

Merged
merged 3 commits into from Aug 17, 2011
Merged

Fixes in ActiveRecord integration #26

merged 3 commits into from Aug 17, 2011

Conversation

giga
Copy link
Contributor

@giga giga commented Jul 27, 2011

Hi,
Could you pull the following fixes for ActiveRecord integration ?
Thanks,

@turadg
Copy link
Contributor

turadg commented Aug 15, 2011

+1

This will allow specs like this to work:

specify {FactoryGirl.build(:user, :role => 'not_a_role').should_not be_valid}

Right now that throws an error.

turadg added a commit that referenced this pull request Aug 17, 2011
@turadg
Merge pull request #26 from giga/master
3fb4d5a 
Backwards incompatible fixes in ActiveRecord integration.
BEFORE: invalid values for enumeration attribute would fail on assignment
AFTER: invalid values assigned but fail validation
@turadg turadg merged commit 3fb4d5a into jeffp:master Aug 17, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@giga @turadg