perlcritic: t+

jeffreykegler · Jan 27, 2013 · 2d5fba1 · 2d5fba1
1 parent 8081531
commit 2d5fba1
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 9 deletions.
diff --git a/r2/lib/Marpa/R2/Scanless.pm b/r2/lib/Marpa/R2/Scanless.pm
@@ -570,6 +570,12 @@ sub Marpa::R2::Scanless::R::range_to_string {
 sub meta_grammar {
     my $hashed_metag;
 
+
+## no critic(RegularExpressions::RequireDotMatchAnything)
+## no critic(RegularExpressions::RequireExtendedFormatting)
+## no critic(RegularExpressions::RequireLineBoundaryMatching)
+## no critic(RegularExpressions::ProhibitEscapedMetacharacters)
+
 ## The code after this line was automatically generated by sl_to_hash.pl
 ## Date: Mon Dec 24 14:19:53 2012
 $hashed_metag = {
@@ -1970,6 +1976,8 @@ $hashed_metag = {
                 };
 ## The code before this line was automatically generated by sl_to_hash.pl
 
+##use critic
+
     my $self = bless [], 'Marpa::R2::Scanless::G';
     $self->[Marpa::R2::Inner::Scanless::G::TRACE_FILE_HANDLE] = \*STDERR;
     $self->_hash_to_runtime($hashed_metag);
@@ -2381,7 +2389,7 @@ sub Marpa::R2::Scanless::G::_source_to_hash {
             SYMBOL: for my $needed_symbol (@needed_symbols) {
                 $seen{$needed_symbol} = 1;
                 if ( $needed_symbol eq '[:ws+]' ) {
-                    push @{ws_rules},
+                    push @ws_rules,
                         {
                         lhs => $needed_symbol,
                         rhs => ['[:Space]'],
@@ -2391,7 +2399,7 @@ sub Marpa::R2::Scanless::G::_source_to_hash {
                     next SYMBOL;
                 } ## end if ( $needed_symbol eq '[:ws+]' )
                 if ( $needed_symbol eq '[:ws*]' ) {
-                    push @{ws_rules},
+                    push @ws_rules,
                         {
                         lhs => $needed_symbol,
                         rhs => ['[:Space]'],
@@ -2401,15 +2409,15 @@ sub Marpa::R2::Scanless::G::_source_to_hash {
                     next SYMBOL;
                 } ## end if ( $needed_symbol eq '[:ws*]' )
                 if ( $needed_symbol eq '[:ws]' ) {
-                    push @{ws_rules},
+                    push @ws_rules,
                         { lhs => '[:ws]', rhs => ['[:ws+]'],  };
                     $needed{'[:ws+]'} = 1;
                     next SYMBOL;
                 } ## end if ( $needed_symbol eq '[:ws]' )
                 if ( $needed_symbol eq '[:Space]' ) {
                     my $true_ws = assign_symbol_by_char_class( $inner_self,
                         '[\p{White_Space}]' );
-                    push @{ws_rules},
+                    push @ws_rules,
                         {
                         lhs  => '[:Space]',
                         rhs  => [ $true_ws->name() ],

diff --git a/r2/lib/Marpa/R2/Stuifzand.pm b/r2/lib/Marpa/R2/Stuifzand.pm
@@ -357,6 +357,11 @@ my %hashed_closures = (
 sub meta_grammar {
     my $hashed_metag;
 
+## no critic(RegularExpressions::RequireDotMatchAnything)
+## no critic(RegularExpressions::RequireExtendedFormatting)
+## no critic(RegularExpressions::RequireLineBoundaryMatching)
+## no critic(RegularExpressions::ProhibitEscapedMetacharacters)
+
 ## The code after this line was automatically generated by sl_to_hash.pl
 ## Date: Mon Dec 24 14:19:53 2012
 $hashed_metag = {
@@ -1757,6 +1762,8 @@ $hashed_metag = {
                 };
 ## The code before this line was automatically generated by sl_to_hash.pl
 
+## use critic
+
     my $self = bless [], 'Marpa::R2::Scanless::G';
     $self->[Marpa::R2::Inner::Scanless::G::TRACE_FILE_HANDLE] = \*STDERR;
     $self->_hash_to_runtime($hashed_metag);
@@ -1989,7 +1996,7 @@ sub parse_rules {
             SYMBOL: for my $needed_symbol (@needed_symbols) {
                 $seen{$needed_symbol} = 1;
                 if ( $needed_symbol eq '[:ws+]' ) {
-                    push @{ws_rules},
+                    push @ws_rules,
                         {
                         lhs => $needed_symbol,
                         rhs => ['[:Space]'],
@@ -1999,7 +2006,7 @@ sub parse_rules {
                     next SYMBOL;
                 } ## end if ( $needed_symbol eq '[:ws+]' )
                 if ( $needed_symbol eq '[:ws*]' ) {
-                    push @{ws_rules},
+                    push @ws_rules,
                         {
                         lhs => $needed_symbol,
                         rhs => ['[:Space]'],
@@ -2009,15 +2016,15 @@ sub parse_rules {
                     next SYMBOL;
                 } ## end if ( $needed_symbol eq '[:ws*]' )
                 if ( $needed_symbol eq '[:ws]' ) {
-                    push @{ws_rules}, { lhs => '[:ws]', rhs => ['[:ws+]'], mask => [0] };
-                    push @{ws_rules}, { lhs => '[:ws]', rhs => ['[:|w]'], mask => [0] };
+                    push @ws_rules, { lhs => '[:ws]', rhs => ['[:ws+]'], mask => [0] };
+                    push @ws_rules, { lhs => '[:ws]', rhs => ['[:|w]'], mask => [0] };
                     $needed{'[:ws+]'} = 1;
                     next SYMBOL;
                 } ## end if ( $needed_symbol eq '[:ws]' )
                 if ( $needed_symbol eq '[:Space]' ) {
                     my $true_ws = assign_symbol_by_char_class( $self,
                         '[\p{White_Space}]' );
-                    push @{ws_rules},
+                    push @ws_rules,
                         {
                         lhs  => '[:Space]',
                         rhs  => [ $true_ws->name() ],