-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In Marpa::R2::ASF, (full traverser) problem with return value from rh_value() #265
Comments
I agree that this issue may /seem/ trivial, but when debugging with Data::Dumper::Concise, the \n are escaped, and I ended up with (ie for [:start], not for the above): |
|
Understand! I have written my own version. But it's the arrayref returned by rh_value() which contains the \n. |
Hi Ron, is the code in repo somewhere? I'd take a look into that \n stuff if/when it is. |
Hi rns. I've pushed my code to Genealogy-Gedcom-Date. Just unpack it and run: |
@ronsavage: Thanks, I'll take a look. BTW, I did get emails about both your comments,FWIW. |
@ronsavage Your alternative code assumes child values are strings, and eliminates all newlines. While this is ideal for your application, it is easy to imagine it being disastrous for another. Each app has to adapt In the above referenced commit, I've added some language to this effect in the doc. If that looks good to you, we can close this issue. |
Hi Jeffrey
Yes, close it.
…On 01/03/17 03:23, Jeffrey Kegler wrote:
Your alternative code assumes child values are strings, and eliminates
all newlines. While this is ideal for your application, it is easy to
imagine it being disastrous for another. Each app has to adapt
|full_traverser()| as needed.
In the above referenced commit, I've added some language to this effect
in the doc. If that looks good to you, we can close this issue.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#265 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABT-H06PZjPyi4hJqULpvUXbL_imXnzks5rhEn4gaJpZM4GSkhm>.
--
Ron Savage - savage.net.au
|
Closed as fixed, as per the last 2 posts. |
In your code for the full traverser, the inner-most loop is:
I write that as:
This was my first output:
Why on earth are there \n embedded in $new_value? If it's deliberate, OK, but I find them a PITA.
By turning the loop into:
I get:
The text was updated successfully, but these errors were encountered: