Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump virt-manager/view-viewer and deps #166

Merged
merged 19 commits into from Mar 25, 2023
Merged

bump virt-manager/view-viewer and deps #166

merged 19 commits into from Mar 25, 2023

Conversation

jouve
Copy link
Contributor

@jouve jouve commented Feb 14, 2021

No description provided.

@doomedraven
Copy link

oh i was just starting to look to get latest virt-manager, can verify this works on mac os x 11.3 beta

With libvirt-python-7.1.0 it is possible install virt-manager on M1 Macs
update libvirt-python to version 7.1.0
@fkpwolf
Copy link

fkpwolf commented Apr 11, 2021

I tried this pr and it can open virt-manager UI but when I open Spice view, I got error:

spice-client-error-quark: Could not auto-redirect USB Device at 20-22: could not claim interface 0(configuration 1): LIBUSB_ERROR_ACCESS(0)

Edit: restart machine and this issue disappeared.

virt-manager.rb Outdated Show resolved Hide resolved
@rafaelreis-r
Copy link

PR #166 on a Air M1

virt-viewer builds fine and works.

virt-manager fails on:

==> /opt/homebrew/Cellar/virt-manager/3.2.0_3/libexec/bin/pip install -v --no-deps --no-binary :all: --ignore-installed /private/tmp/virt-manager--PyGObject-2021
Last 15 lines from /Users/rafaelreisr/Library/Logs/Homebrew/virt-manager/07.pip:
  ERROR: Failed building wheel for PyGObject
Failed to build PyGObject
ERROR: Could not build wheels for PyGObject which use PEP 517 and cannot be installed directly
Exception information:
Traceback (most recent call last):
  File "/opt/homebrew/Cellar/virt-manager/3.2.0_3/libexec/lib/python3.9/site-packages/pip/_internal/cli/base_command.py", line 180, in _main
    status = self.run(options, args)
  File "/opt/homebrew/Cellar/virt-manager/3.2.0_3/libexec/lib/python3.9/site-packages/pip/_internal/cli/req_command.py", line 204, in wrapper
    return func(self, options, args)
  File "/opt/homebrew/Cellar/virt-manager/3.2.0_3/libexec/lib/python3.9/site-packages/pip/_internal/commands/install.py", line 360, in run
    raise InstallationError(
pip._internal.exceptions.InstallationError: Could not build wheels for PyGObject which use PEP 517 and cannot be installed directly
WARNING: You are using pip version 21.1.1; however, version 21.1.3 is available.
You should consider upgrading via the '/opt/homebrew/Cellar/virt-manager/3.2.0_3/libexec/bin/python3.9 -m pip install --upgrade pip' command.
Removed build tracker: '/private/tmp/pip-req-tracker-25m6ew6y'

I read somewhere that this seems to be an issue with that version of pip and M1 Macs. Version 21.1.3 works fine. I have updated pip to the latest version on home-brew, but don't know exactly how to do it on virt-manager build environment.

@jouve
Copy link
Contributor Author

jouve commented Jul 7, 2021

I can only test on catalina

@jouve
Copy link
Contributor Author

jouve commented Jul 14, 2021

@rafaelreis-r can you try the following ?

curl -O https://files.pythonhosted.org/packages/51/2f/4d5d5afb7000b9151e33952b59163c9389bd867ac6fe85d62f85831fa061/PyGObject-3.40.1.tar.gz
tar xf PyGObject-3.40.1.tar.gz
cd PyGObject-3.40.1/
python3.9 -m venv .venv
./.venv/bin/pip install --upgrade pip==21.1.1
./.venv/bin/pip wheel -v .

@rafaelreis-r
Copy link

@rafaelreis-r can you try the following ?

Commands worked fine, but build process still presents same error.

  Created wheel for PyGObject: filename=PyGObject-3.40.1-cp39-cp39-macosx_11_0_arm64.whl size=236939 sha256=56d3126adf1682b0c9a82acbc655e8f7ce1fa48753c71d5967a8db246a5b74ab
  Stored in directory: /Users/rafaelreisr/Library/Caches/pip/wheels/22/64/50/c8c8c647d3bf799e350edaba27905aa28e0a093f0f9d2e9ac6
Successfully built PyGObject
WARNING: You are using pip version 21.1.1; however, version 21.1.3 is available.
You should consider upgrading via the '/opt/homebrew/Library/Taps/jeffreywildman/homebrew-virt-manager/PyGObject-3.40.1/.venv/bin/python3.9 -m pip install --upgrade pip' command.
Removed build tracker: '/private/var/folders/_1/41hvxkq93p71_s_g6_6d4mnr0000gn/T/pip-req-tracker-ugm2rck7' 

Installation:

==> Installing jeffreywildman/virt-manager/virt-manager
==> Patching
==> python3 -m venv --system-site-packages /opt/homebrew/Cellar/virt-manager/3.2.0_4/libexec
==> /opt/homebrew/Cellar/virt-manager/3.2.0_4/libexec/bin/pip install -v --no-deps --no-binary :all: --ignore-installed /private/tmp/virt-manager--certifi-20210715-14749-4ogwsh/certifi-2021.5.30
==> /opt/homebrew/Cellar/virt-manager/3.2.0_4/libexec/bin/pip install -v --no-deps --no-binary :all: --ignore-installed /private/tmp/virt-manager--charset-normalizer-20210715-14749-tufesi/charset-normalizer
==> /opt/homebrew/Cellar/virt-manager/3.2.0_4/libexec/bin/pip install -v --no-deps --no-binary :all: --ignore-installed /private/tmp/virt-manager--idna-20210715-14749-1dtint7/idna-3.2
==> /opt/homebrew/Cellar/virt-manager/3.2.0_4/libexec/bin/pip install -v --no-deps --no-binary :all: --ignore-installed /private/tmp/virt-manager--libvirt-python-20210715-14749-bpb72i/libvirt-python-7.5.0
==> /opt/homebrew/Cellar/virt-manager/3.2.0_4/libexec/bin/pip install -v --no-deps --no-binary :all: --ignore-installed /private/tmp/virt-manager--pycairo-20210715-14749-1etdh6y/pycairo-1.20.1
==> /opt/homebrew/Cellar/virt-manager/3.2.0_4/libexec/bin/pip install -v --no-deps --no-binary :all: --ignore-installed /private/tmp/virt-manager--PyGObject-20210715-14749-10sxwp4/PyGObject-3.40.1
Last 15 lines from /Users/rafaelreisr/Library/Logs/Homebrew/virt-manager/07.pip:
  error: command '/opt/homebrew/Library/Homebrew/shims/mac/super/clang' failed with exit code 1
  Building wheel for PyGObject (PEP 517): finished with status 'error'
  ERROR: Failed building wheel for PyGObject
Failed to build PyGObject
ERROR: Could not build wheels for PyGObject which use PEP 517 and cannot be installed directly
Exception information:
Traceback (most recent call last):
  File "/opt/homebrew/Cellar/virt-manager/3.2.0_4/libexec/lib/python3.9/site-packages/pip/_internal/cli/base_command.py", line 180, in _main
    status = self.run(options, args)
  File "/opt/homebrew/Cellar/virt-manager/3.2.0_4/libexec/lib/python3.9/site-packages/pip/_internal/cli/req_command.py", line 205, in wrapper
    return func(self, options, args)
  File "/opt/homebrew/Cellar/virt-manager/3.2.0_4/libexec/lib/python3.9/site-packages/pip/_internal/commands/install.py", line 360, in run
    raise InstallationError(
pip._internal.exceptions.InstallationError: Could not build wheels for PyGObject which use PEP 517 and cannot be installed directly
Removed build tracker: '/private/tmp/pip-req-tracker-nhy48g95'

Do not report this issue to Homebrew/brew or Homebrew/core!

I noticed pyGobject is part of Homebrew already. I was able to go further by adding it to the rb file instead of compiling it in the install process. That compiles, but it leads me to a segmentation fault documented on this comment: #173 (comment)

@theranger
Copy link
Contributor

theranger commented Aug 21, 2021

I can confirm that using replacing PyGobject resource with depends_on "pygobject3" makes it possible to complete the installation on BigSur (Intel CPU). Application runs, connects to server, but opening any of the virtual instances throws Python memory management exception:

Python(78266,0x10b117e00) malloc: *** error for object 0x7fb9c904e450: pointer being freed was not allocated
Python(78266,0x10b117e00) malloc: *** set a breakpoint in malloc_error_break to debug

Have not yet managed to dig deeper into this.

One more note, this error happened already even if only libvirt-python was updated to the latest version and all other dependencies were not touched.

@Damenly
Copy link

Damenly commented Sep 2, 2021

Well, thanks to Jouve, I fixed the pygobject installation issue in my branch but there is a segmentation fault issue: https://gitlab.gnome.org/GNOME/pygobject/-/issues/455
It seems a bug of pygobject but no one fixed it in the past 7 moths.

@jouve
Copy link
Contributor Author

jouve commented Sep 2, 2021

pypi and homebrew-core/pyobject3 are the same archive (3.40.1):

there are not a lot of changes between 3.40.1 and master, so it might be the same bug :
https://gitlab.gnome.org/GNOME/pygobject/-/compare/3.40.1...master?from_project_id=416

Damenly added a commit to Damenly/pygobject that referenced this pull request Sep 4, 2021
There is one bugs in py. The api only returns the address of exec not
closure. On linux arm64 and x86_64 platforms, exec adrress is same as
closre. However, on Macos arm64, it is not true. Then segmentation
fault happens while calling g_callable_info_free_closure() on exec ptr.

Try the C code:

========================================================================

void puts_binding(ffi_cif *cif, void *ret, void* args[],
                  void *stream)
{
  *(ffi_arg *)ret = fputs(*(char **)args[0], (FILE *)stream);
}

typedef int (*puts_t)(char *);

int main()
{
  ffi_cif cif;
  ffi_type *args[1];
  ffi_closure *closure;

  void *bound_puts;
  int rc;

  /* Allocate closure and bound_puts */
  closure = ffi_closure_alloc(sizeof(ffi_closure), &bound_puts);

  if (closure)
    {
      /* Initialize the argument info vectors */
      args[0] = &ffi_type_pointer;

      /* Initialize the cif */
      if (ffi_prep_cif(&cif, FFI_DEFAULT_ABI, 1,
                       &ffi_type_sint, args) == FFI_OK)
        {
          /* Initialize the closure, setting stream to stdout */
          if (ffi_prep_closure_loc(closure, &cif, puts_binding,
                                   stdout, bound_puts) == FFI_OK)
            {
              rc = ((puts_t)bound_puts)("");
              /* rc now holds the result of the call to fputs */
            }
        }

  printf("closure:%p exec: %p\n", closure, bound_puts);
  /* Deallocate both closure, and bound_puts */
  ffi_closure_free(closure);

  return 0;
}
========================================================================

I tried to fix it but there are some bugs in pyobject which also cause
segmentation faults.

I'm not a pundit in these messy code so just do hacks in pyobject to
fix it.

Link: https://gitlab.gnome.org/GNOME/pygobject/-/issues/455
Link: jeffreywildman/homebrew-virt-manager#166 (comment)
Signed-off-by: Su Yue <l@damenly.su>
Damenly added a commit to Damenly/pygobject that referenced this pull request Sep 4, 2021
There are bugs in pyobject and gobject-introspection.
The API g_callable_info_prepare_closure() only returns the address
of exec not closure.
On linux arm64 and x86_64 platforms, exec address is same as
closure. However, on Macos arm64, it is not true. Then segmentation
fault happens while calling g_callable_info_free_closure() on exec ptr.

Try the C code:

========================================================================

void puts_binding(ffi_cif *cif, void *ret, void* args[],
                  void *stream)
{
  *(ffi_arg *)ret = fputs(*(char **)args[0], (FILE *)stream);
}

typedef int (*puts_t)(char *);

int main()
{
  ffi_cif cif;
  ffi_type *args[1];
  ffi_closure *closure;

  void *bound_puts;
  int rc;

  /* Allocate closure and bound_puts */
  closure = ffi_closure_alloc(sizeof(ffi_closure), &bound_puts);

  if (closure)
    {
      /* Initialize the argument info vectors */
      args[0] = &ffi_type_pointer;

      /* Initialize the cif */
      if (ffi_prep_cif(&cif, FFI_DEFAULT_ABI, 1,
                       &ffi_type_sint, args) == FFI_OK)
        {
          /* Initialize the closure, setting stream to stdout */
          if (ffi_prep_closure_loc(closure, &cif, puts_binding,
                                   stdout, bound_puts) == FFI_OK)
            {
              rc = ((puts_t)bound_puts)("");
              /* rc now holds the result of the call to fputs */
            }
        }

  printf("closure:%p exec: %p\n", closure, bound_puts);
  /* Deallocate both closure, and bound_puts */
  ffi_closure_free(closure);

  return 0;
}
========================================================================

I tried to fix it but there are some bugs in pyobject which also cause
segmentation faults.

I'm not a pundit in these messy code so just do hacks in pyobject to
fix it.

Link: https://gitlab.gnome.org/GNOME/pygobject/-/issues/455
Link: jeffreywildman/homebrew-virt-manager#166 (comment)
Signed-off-by: Su Yue <l@damenly.su>
Damenly added a commit to Damenly/pygobject that referenced this pull request Sep 4, 2021
There are bugs in pyobject and gobject-introspection.
The API g_callable_info_prepare_closure() only returns the address
of exec not closure.
On linux arm64 and x86_64 platforms, exec address is same as
closure. However, on Macos arm64, it is not true. Then segmentation
fault happens while calling g_callable_info_free_closure() on exec ptr.

Try the C code:

========================================================================

void puts_binding(ffi_cif *cif, void *ret, void* args[],
                  void *stream)
{
  *(ffi_arg *)ret = fputs(*(char **)args[0], (FILE *)stream);
}

typedef int (*puts_t)(char *);

int main()
{
  ffi_cif cif;
  ffi_type *args[1];
  ffi_closure *closure;

  void *bound_puts;
  int rc;

  /* Allocate closure and bound_puts */
  closure = ffi_closure_alloc(sizeof(ffi_closure), &bound_puts);

  if (closure)
    {
      /* Initialize the argument info vectors */
      args[0] = &ffi_type_pointer;

      /* Initialize the cif */
      if (ffi_prep_cif(&cif, FFI_DEFAULT_ABI, 1,
                       &ffi_type_sint, args) == FFI_OK)
        {
          /* Initialize the closure, setting stream to stdout */
          if (ffi_prep_closure_loc(closure, &cif, puts_binding,
                                   stdout, bound_puts) == FFI_OK)
            {
              rc = ((puts_t)bound_puts)("");
              /* rc now holds the result of the call to fputs */
            }
        }

  printf("closure:%p exec: %p\n", closure, bound_puts);
  /* Deallocate both closure, and bound_puts */
  ffi_closure_free(closure);

  return 0;
}
========================================================================

I tried to fix it but there are some bugs in pyobject which also cause
segmentation faults.

I'm not a pundit in these messy code so just do hacks in pyobject to
fix it.

Link: https://gitlab.gnome.org/GNOME/pygobject/-/issues/455
Link: jeffreywildman/homebrew-virt-manager#166 (comment)
Signed-off-by: Su Yue <l@damenly.su>
@Damenly
Copy link

Damenly commented Sep 4, 2021

I just fixed segmentation faults with some hacks in my branch.
Anyone who interests in it could look at this.

Tested it in arm64 only:
Screen Shot 2021-09-04 at 14 27 02

@rafaelreis-r
Copy link

@Damenly I can confirm your branch compiles and runs fine on my M1 Air!

However I gave up on homebrew virt-manager for arm64 months ago since this hadn't had a solution all this time.

In case anybody is interested I went the docker way using https://github.com/m-bers/docker-virt-manager on the host. Virt-manager on a webpage :)

@krishjainx
Copy link

@jouve Should probably close this pull request. My pull request upgrades the libvirt-python version to a more suitable one.

@k0ste
Copy link

k0ste commented Oct 21, 2021

I just fixed segmentation faults with some hacks in my branch. Anyone who interests in it could look at this.

Tested it in arm64 only: Screen Shot 2021-09-04 at 14 27 02

Can't fill issue to your repo

?1 ~ % brew install damenly/virt-manager/virt-manager
==> Downloading https://files.pythonhosted.org/packages/6d/78/f8db8d57f520a54f0b8a438319c342c61c22759d8f9a1cd2e2180b5e5ea9/certifi-2021.5.30.
######################################################################## 100.0%
==> Downloading https://files.pythonhosted.org/packages/e7/4e/2af0238001648ded297fb54ceb425ca26faa15b341b4fac5371d3938666e/charset-normalizer
######################################################################## 100.0%
==> Downloading https://files.pythonhosted.org/packages/cb/38/4c4d00ddfa48abe616d7e572e02a04273603db446975ab46bbcd36552005/idna-3.2.tar.gz
######################################################################## 100.0%
==> Downloading https://files.pythonhosted.org/packages/a0/24/a8eefb64e4c7baf5a0006dd3b2c5ce6aef334ff15c9c29066c6791a72fe1/libvirt-python-7.6
######################################################################## 100.0%
==> Downloading https://files.pythonhosted.org/packages/bc/3f/64e6e066d163fbcf13213f9eeda0fc83376243335ea46a66cefd70d62e8f/pycairo-1.20.1.tar
######################################################################## 100.0%
==> Cloning https://github.com/Damenly/pygobject.git
Cloning into '/Users/k0ste/Library/Caches/Homebrew/virt-manager--PyGObject--git'...
==> Checking out branch arm64e_tmp_fix
Already on 'arm64e_tmp_fix'
Your branch is up to date with 'origin/arm64e_tmp_fix'.
==> Downloading https://files.pythonhosted.org/packages/e7/01/3569e0b535fb2e4a6c384bdbed00c55b9d78b5084e0fb7f4d0bf523d7670/requests-2.26.0.ta
######################################################################## 100.0%
==> Downloading https://files.pythonhosted.org/packages/4f/5a/597ef5911cb8919efe4d86206aa8b2658616d676a7088f0825ca08bd7cb8/urllib3-1.26.6.tar
######################################################################## 100.0%
==> Downloading https://virt-manager.org/download/sources/virt-manager/virt-manager-3.2.0.tar.gz
Already downloaded: /Users/k0ste/Library/Caches/Homebrew/downloads/076c9cd7ebc326805adadb4c0525544e05ef6183614a8937cd21a39364835fe6--virt-manager-3.2.0.tar.gz
==> Installing virt-manager from damenly/virt-manager
==> Patching
==> python3 -m venv --system-site-packages /usr/local/Cellar/virt-manager/3.2.0_5/libexec
==> python3 -m venv --upgrade-deps /usr/local/Cellar/virt-manager/3.2.0_5/libexec
==> /usr/local/Cellar/virt-manager/3.2.0_5/libexec/bin/pip install -v --no-deps --no-binary :all: --ignore-installed /private/tmp/virt-manage
==> /usr/local/Cellar/virt-manager/3.2.0_5/libexec/bin/pip install -v --no-deps --no-binary :all: --ignore-installed /private/tmp/virt-manage
==> /usr/local/Cellar/virt-manager/3.2.0_5/libexec/bin/pip install -v --no-deps --no-binary :all: --ignore-installed /private/tmp/virt-manage
==> /usr/local/Cellar/virt-manager/3.2.0_5/libexec/bin/pip install -v --no-deps --no-binary :all: --ignore-installed /private/tmp/virt-manage
Last 15 lines from /Users/k0ste/Library/Logs/Homebrew/virt-manager/06.pip:
    Running setup.py install for libvirt-python: started
    Running command /usr/local/Cellar/virt-manager/3.2.0_5/libexec/bin/python -u -c 'import io, os, sys, setuptools, tokenize; sys.argv[0] = '"'"'/private/tmp/virt-manager--libvirt-python-20211021-44666-nme0am/libvirt-python-7.6.0/setup.py'"'"'; __file__='"'"'/private/tmp/virt-manager--libvirt-python-20211021-44666-nme0am/libvirt-python-7.6.0/setup.py'"'"';f = getattr(tokenize, '"'"'open'"'"', open)(__file__) if os.path.exists(__file__) else io.StringIO('"'"'from setuptools import setup; setup()'"'"');code = f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' install --record /private/tmp/pip-record-yov7xi17/install-record.txt --single-version-externally-managed --compile --install-headers /usr/local/Cellar/virt-manager/3.2.0_5/libexec/include/site/python3.9/libvirt-python
    running install
    running build
    /usr/local/Homebrew/Library/Homebrew/shims/mac/super/pkg-config --print-errors --atleast-version=0.9.11 libvirt
    /usr/local/Cellar/virt-manager/3.2.0_5/libexec/bin/python generator.py libvirt /usr/local/Cellar/libvirt/7.8.0/share/libvirt/api/libvirt-api.xml
    Found 492 functions in /usr/local/Cellar/libvirt/7.8.0/share/libvirt/api/libvirt-api.xml
    Found 0 functions in libvirt-override-api.xml
    Generated 402 wrapper functions
    Missing type converters:
    int *:1
    ERROR: failed virNodeDeviceGetAutostart
    error: command '/usr/local/Cellar/virt-manager/3.2.0_5/libexec/bin/python' failed with exit code 1
    Running setup.py install for libvirt-python: finished with status 'error'
ERROR: Command errored out with exit status 1: /usr/local/Cellar/virt-manager/3.2.0_5/libexec/bin/python -u -c 'import io, os, sys, setuptools, tokenize; sys.argv[0] = '"'"'/private/tmp/virt-manager--libvirt-python-20211021-44666-nme0am/libvirt-python-7.6.0/setup.py'"'"'; __file__='"'"'/private/tmp/virt-manager--libvirt-python-20211021-44666-nme0am/libvirt-python-7.6.0/setup.py'"'"';f = getattr(tokenize, '"'"'open'"'"', open)(__file__) if os.path.exists(__file__) else io.StringIO('"'"'from setuptools import setup; setup()'"'"');code = f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' install --record /private/tmp/pip-record-yov7xi17/install-record.txt --single-version-externally-managed --compile --install-headers /usr/local/Cellar/virt-manager/3.2.0_5/libexec/include/site/python3.9/libvirt-python Check the logs for full command output.

If reporting this issue please do so at (not Homebrew/brew or Homebrew/core):
  https://github.com/damenly/homebrew-virt-manager/issues

@Damenly
Copy link

Damenly commented Oct 22, 2021

I just fixed segmentation faults with some hacks in my branch. Anyone who interests in it could look at this.
Tested it in arm64 only: Screen Shot 2021-09-04 at 14 27 02

Can't fill issue to your repo

?1 ~ % brew install damenly/virt-manager/virt-manager
==> Downloading https://files.pythonhosted.org/packages/6d/78/f8db8d57f520a54f0b8a438319c342c61c22759d8f9a1cd2e2180b5e5ea9/certifi-2021.5.30.
######################################################################## 100.0%
==> Downloading https://files.pythonhosted.org/packages/e7/4e/2af0238001648ded297fb54ceb425ca26faa15b341b4fac5371d3938666e/charset-normalizer
######################################################################## 100.0%
==> Downloading https://files.pythonhosted.org/packages/cb/38/4c4d00ddfa48abe616d7e572e02a04273603db446975ab46bbcd36552005/idna-3.2.tar.gz
######################################################################## 100.0%
==> Downloading https://files.pythonhosted.org/packages/a0/24/a8eefb64e4c7baf5a0006dd3b2c5ce6aef334ff15c9c29066c6791a72fe1/libvirt-python-7.6
######################################################################## 100.0%
==> Downloading https://files.pythonhosted.org/packages/bc/3f/64e6e066d163fbcf13213f9eeda0fc83376243335ea46a66cefd70d62e8f/pycairo-1.20.1.tar
######################################################################## 100.0%
==> Cloning https://github.com/Damenly/pygobject.git
Cloning into '/Users/k0ste/Library/Caches/Homebrew/virt-manager--PyGObject--git'...
==> Checking out branch arm64e_tmp_fix
Already on 'arm64e_tmp_fix'
Your branch is up to date with 'origin/arm64e_tmp_fix'.
==> Downloading https://files.pythonhosted.org/packages/e7/01/3569e0b535fb2e4a6c384bdbed00c55b9d78b5084e0fb7f4d0bf523d7670/requests-2.26.0.ta
######################################################################## 100.0%
==> Downloading https://files.pythonhosted.org/packages/4f/5a/597ef5911cb8919efe4d86206aa8b2658616d676a7088f0825ca08bd7cb8/urllib3-1.26.6.tar
######################################################################## 100.0%
==> Downloading https://virt-manager.org/download/sources/virt-manager/virt-manager-3.2.0.tar.gz
Already downloaded: /Users/k0ste/Library/Caches/Homebrew/downloads/076c9cd7ebc326805adadb4c0525544e05ef6183614a8937cd21a39364835fe6--virt-manager-3.2.0.tar.gz
==> Installing virt-manager from damenly/virt-manager
==> Patching
==> python3 -m venv --system-site-packages /usr/local/Cellar/virt-manager/3.2.0_5/libexec
==> python3 -m venv --upgrade-deps /usr/local/Cellar/virt-manager/3.2.0_5/libexec
==> /usr/local/Cellar/virt-manager/3.2.0_5/libexec/bin/pip install -v --no-deps --no-binary :all: --ignore-installed /private/tmp/virt-manage
==> /usr/local/Cellar/virt-manager/3.2.0_5/libexec/bin/pip install -v --no-deps --no-binary :all: --ignore-installed /private/tmp/virt-manage
==> /usr/local/Cellar/virt-manager/3.2.0_5/libexec/bin/pip install -v --no-deps --no-binary :all: --ignore-installed /private/tmp/virt-manage
==> /usr/local/Cellar/virt-manager/3.2.0_5/libexec/bin/pip install -v --no-deps --no-binary :all: --ignore-installed /private/tmp/virt-manage
Last 15 lines from /Users/k0ste/Library/Logs/Homebrew/virt-manager/06.pip:
    Running setup.py install for libvirt-python: started
    Running command /usr/local/Cellar/virt-manager/3.2.0_5/libexec/bin/python -u -c 'import io, os, sys, setuptools, tokenize; sys.argv[0] = '"'"'/private/tmp/virt-manager--libvirt-python-20211021-44666-nme0am/libvirt-python-7.6.0/setup.py'"'"'; __file__='"'"'/private/tmp/virt-manager--libvirt-python-20211021-44666-nme0am/libvirt-python-7.6.0/setup.py'"'"';f = getattr(tokenize, '"'"'open'"'"', open)(__file__) if os.path.exists(__file__) else io.StringIO('"'"'from setuptools import setup; setup()'"'"');code = f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' install --record /private/tmp/pip-record-yov7xi17/install-record.txt --single-version-externally-managed --compile --install-headers /usr/local/Cellar/virt-manager/3.2.0_5/libexec/include/site/python3.9/libvirt-python
    running install
    running build
    /usr/local/Homebrew/Library/Homebrew/shims/mac/super/pkg-config --print-errors --atleast-version=0.9.11 libvirt
    /usr/local/Cellar/virt-manager/3.2.0_5/libexec/bin/python generator.py libvirt /usr/local/Cellar/libvirt/7.8.0/share/libvirt/api/libvirt-api.xml
    Found 492 functions in /usr/local/Cellar/libvirt/7.8.0/share/libvirt/api/libvirt-api.xml
    Found 0 functions in libvirt-override-api.xml
    Generated 402 wrapper functions
    Missing type converters:
    int *:1
    ERROR: failed virNodeDeviceGetAutostart
    error: command '/usr/local/Cellar/virt-manager/3.2.0_5/libexec/bin/python' failed with exit code 1
    Running setup.py install for libvirt-python: finished with status 'error'
ERROR: Command errored out with exit status 1: /usr/local/Cellar/virt-manager/3.2.0_5/libexec/bin/python -u -c 'import io, os, sys, setuptools, tokenize; sys.argv[0] = '"'"'/private/tmp/virt-manager--libvirt-python-20211021-44666-nme0am/libvirt-python-7.6.0/setup.py'"'"'; __file__='"'"'/private/tmp/virt-manager--libvirt-python-20211021-44666-nme0am/libvirt-python-7.6.0/setup.py'"'"';f = getattr(tokenize, '"'"'open'"'"', open)(__file__) if os.path.exists(__file__) else io.StringIO('"'"'from setuptools import setup; setup()'"'"');code = f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' install --record /private/tmp/pip-record-yov7xi17/install-record.txt --single-version-externally-managed --compile --install-headers /usr/local/Cellar/virt-manager/3.2.0_5/libexec/include/site/python3.9/libvirt-python Check the logs for full command output.

If reporting this issue please do so at (not Homebrew/brew or Homebrew/core):
  https://github.com/damenly/homebrew-virt-manager/issues

Thanks for the report! I just bumped my repo. Try:

brew untap damenly/virt-manager
brew tap damenly/virt-manager
brew install virt-manager --HEAD

@k0ste
Copy link

k0ste commented Oct 22, 2021

@Damenly nice, thanks!
Currently the only issue I was get - virt-manager don't ask for password. I check on linux laptop and virt-manager prompt for password before connection
image

In archlinux this is solved via x11-ssh-askpass optdependency
https://github.com/archlinux/svntogit-community/blob/packages/virt-manager/trunk/PKGBUILD#L16

@doomedraven
Copy link

doomedraven commented Oct 22, 2021 via email

@jouve
Copy link
Contributor Author

jouve commented May 9, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet