Fix addons without repo/unused repository checks

[tstrul1]

after upgrading to python3, im getting this error while performing these checks:

ERROR <general>: EXCEPTION Thrown (PythonToCppException) : -->Python callback/script returned the following error<--
                                                    - NOTE: IGNORING THIS CAN LEAD TO MEMORY LEAKS!
                                                   Error Type: <class 'TypeError'>
                                                   Error Contents: can only concatenate str (not "bytes") to str
                                                   Traceback (most recent call last):
                                                     File "C:\Users\home\AppData\Roaming\Kodi\addons\script.kcleaner\default.py", line 1262, in getPathAddons
                                                       xmldoc = minidom.parseString(httpdata)
                                                     File "C:\Program Files (x86)\Kodi\system\python\Lib\xml\dom\minidom.py", line 1969, in parseString
                                                       return expatbuilder.parseString(string)
                                                     File "C:\Program Files (x86)\Kodi\system\python\Lib\xml\dom\expatbuilder.py", line 925, in parseString
                                                       return builder.parseString(string)
                                                     File "C:\Program Files (x86)\Kodi\system\python\Lib\xml\dom\expatbuilder.py", line 223, in parseString
                                                       parser.Parse(string, True)
                                                   xml.parsers.expat.ExpatError: not well-formed (invalid token): line 186, column 79
                                                   
                                                   During handling of the above exception, another exception occurred:
                                                   
                                                   Traceback (most recent call last):
                                                     File "C:\Users\home\AppData\Roaming\Kodi\addons\script.kcleaner\default.py", line 1963, in <module>
                                                       intCancel = ProcessAddons(0)
                                                     File "C:\Users\home\AppData\Roaming\Kodi\addons\script.kcleaner\default.py", line 1053, in ProcessAddons
                                                       AddonsInRepo += GetAddonsInRepo(repoxml, r)
                                                     File "C:\Users\home\AppData\Roaming\Kodi\addons\script.kcleaner\default.py", line 1190, in GetAddonsInRepo
                                                       id = getPathAddons(ri, repo)
                                                     File "C:\Users\home\AppData\Roaming\Kodi\addons\script.kcleaner\default.py", line 1264, in getPathAddons
                                                       xbmc.log("KCLEANER >> ERROR PARSING REPO >> " + str(e).encode('utf-8'))
                                                   TypeError: can only concatenate str (not "bytes") to str
                                                   -->End of Python script error report<--

[jeffski10]

I can't replicate this issue. What repo path is it failing to parse as encoding the path seems logical to me.

[tstrul1]

Hi,
It happens for some repositories for example repository.DejaVu

BTW are you sure this part is about encoding the path? I think its encoding the exception

[jeffski10]

So debugged this. Its happening as the repo xml is invalid for one of the included repos ' unencoded &
Hadn't realised this was just the error message so you you are right no need to encode.

[tstrul1]

Thanks a lot for your quick help!
btw im not sure if you keep adding features to this addon but if you do, I think removal of orphaned dependencies could make this the perfect cleaning add-on :)

[jeffski10]

Not at the moment. I'd uploaded this as the developer had gone AWOL but has since reinstated the repo and the link updated on the forums. If it does become unmaintained fully then I might think about making further amends.

[tstrul1]

Thanks for helping,
I see his user on kodi forum is disabled and i cant find original source code anywhere.
Any idea how to contact the developer with this change?

[jeffski10]

Yeah, saw that - He disappeared completely so I uploaded the plugin code I had a copy of to git so it could be found. Not sure it was ever here in the past. His repo is back now but I don't see an obvious way to contact either.