Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bugfix]: properly clean up MPV on quit, use pid for socket #627

Open
wants to merge 2 commits into
base: development
Choose a base branch
from
Open

[bugfix]: properly clean up MPV on quit, use pid for socket #627

wants to merge 2 commits into from

Conversation

kgarner7
Copy link
Collaborator

This PR has two separate fixes:

  1. Use PID for socket to allow multi-user (and make development a bit cleaner)
  2. On Unix-based systems, delete the socket file on close (Windows appears to remove the pipe on close). Because teardown is async, the before-quit event is tweaked to prevent closing until the operation completes.

Resolves #622

@kgarner7 kgarner7 added bug Something isn't working MPV Issues related to MPV player labels May 26, 2024
@kgarner7 kgarner7 requested a review from jeffvli May 26, 2024 05:26
@vercel Vercel
Copy link

vercel bot commented May 26, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
feishin ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 26, 2024 5:28am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffvli jeffvli Awaiting requested review from jeffvli

Assignees
No one assigned
Labels
bug Something isn't working MPV Issues related to MPV player
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MPV playback does not work with multiple users
1 participant
@kgarner7