-
-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jellyfin Scrobbling: Listening to a song records it 2x+ times #126
Comments
Thanks for opening this. I noticed there were additional issues the lastfm scrobbling on Jellyfin but didn't realize the play count was being recorded multiple times as well. |
Seems like Jellyfin marks the song as "Played" (adds 1 to the play count) when sending the /Sessions/Playing request. On the default Jellyfin web UI this request is sent as soon as a song is started, which means that if you quickly skip through songs with the I'm thinking it would be better to have it only when the song is completed (90% listened or past 4 minutes) which is consistent with the lastfm scrobble. Thoughts? |
Yeah, that's kind of what I was expecting, that once you listened to at least most of the song it would count. Plenty of times where you're just flipping through and don't want it to go up. If Last.fm does 90%, I agree to stick with that! |
- Remove /sessions/playing (lastfm plugin will no longer show currently playing) - Add pause event for crossfade players - Add debounce to seek slider with puase/play events for jellyfin
I just wanted to mention that I encountered a few issues that somehow relate to this one:
Also the Last.fm plugin marks a song as played after 100%, when its played in the web player. (Maybe there is an option to change that) |
This is due to the crossfade player implementation and how the scrobbling was implemented for Subsonic-API servers. For Subsonic, a In the case of Jellyfin, I replaced it with the
It should stop properly when in gapless mode (crossfade duration = 0), but there's a bug when crossfade is enabled. It's fixed in #127 and should go out with the next release though.
The plugin is checking the |
- Remove /sessions/playing (lastfm plugin will no longer show currently playing) - Add pause event for crossfade players - Add debounce to seek slider with puase/play events for jellyfin
- Prevents playCount increment when quickly skipping through songs
Describe the bug
With Scrobbling turned on, and listening to songs from a Jellyfin server, it appears to count each listen multiple times.
To Reproduce
Steps to reproduce the behavior:
x. Turn on scrobbling
Expected behavior
After hitting the threshold of "played", the count would go up by 1
Screenshots
(I've been meaning to get a dev version up and running so I could provide a bit more context, but) Here's the track I was playing, and about as I could get to when it flipped over to 2 plays
Desktop (please complete the following information):
Additional context
Single tracks on albums replaying automatically is a separate issue that I should probably put elsewhere.
The text was updated successfully, but these errors were encountered: