Advanced album filtering #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add check picker component - Add filter hook - Add filter component - Add support for favorite filter - Add support for genre filter (AND/OR)
- Return filtered data from each step - Set data dynamically by selected filters - Add separate check picker clear buttons
jeffvli
force-pushed
the
feature-66-filters
branch
2 times, most recently
from
6e9e3f1
to
8c030fa
Compare
- Add reset button for each section - Focus check picker search bar on open - Remove default reset button - Prevent overflow of filter window - Move filter button to sidetitle - Move album count to title - Move filter button to separate file
- genre list - now playing
- Consistent tab styles - Popover placement
jeffvli
force-pushed
the
feature-66-filters
branch
from
8c030fa
to
325bdc9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #66
Preview (subject to change)
Note:
ANDfilters have limited functionality for Subsonic-API due to not supporting multi-genre and multi-artist fields.