Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve slider components #292

Merged
merged 8 commits into from
Apr 10, 2022
Merged

Improve slider components #292

merged 8 commits into from
Apr 10, 2022

Commits on Apr 10, 2022

  1. Add react-slider package

    @jeffvli
    jeffvli committed Apr 10, 2022
    Configuration menu
    Copy the full SHA
    45af23a View commit details
    Browse the repository at this point in the history

  2. Add custom slider component

    @jeffvli
    jeffvli committed Apr 10, 2022
    Configuration menu
    Copy the full SHA
    2775371 View commit details
    Browse the repository at this point in the history

  3. Extend slider props 

    - Add toolTipType (str 'text' | 'time')
- Add hasToolTip (boolean)
    @jeffvli
    jeffvli committed Apr 10, 2022
    Configuration menu
    Copy the full SHA
    030be99 View commit details
    Browse the repository at this point in the history

  4. Normalize seek slider behavior 

    - Update current time on drag/drop
- Memoize formatted times
    @jeffvli
    jeffvli committed Apr 10, 2022
    Configuration menu
    Copy the full SHA
    42acc71 View commit details
    Browse the repository at this point in the history

  5. Remove manualSeek implementation 

    Previous slider did not have callbacks for when drag is completed
    @jeffvli
    jeffvli committed Apr 10, 2022
    Configuration menu
    Copy the full SHA
    89e66f4 View commit details
    Browse the repository at this point in the history

  6. Enable "stop" button when paused (#273)

    @jeffvli
    jeffvli committed Apr 10, 2022
    Configuration menu
    Copy the full SHA
    0fd50e8 View commit details
    Browse the repository at this point in the history

  7. Adjust slider styling

    @jeffvli
    jeffvli committed Apr 10, 2022
    Configuration menu
    Copy the full SHA
    d532b7e View commit details
    Browse the repository at this point in the history

  8. Replace volume slider with new component

    @jeffvli
    jeffvli committed Apr 10, 2022
    Configuration menu
    Copy the full SHA
    417d5ca View commit details
    Browse the repository at this point in the history