This repository has been archived by the owner on May 27, 2018. It is now read-only.
Fixes #8: 'downgrades' some of the array-related API calls #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code uses features like
[].indexOf()and[].slice.call()on objects that don't support it on IE8. I've added fallbacks/replacements where needed in order to address this.jasmine.DOM.indexOfhas been added as replacement for[].indexOf()(uses native function on browsers that support it)jasmine.DOM.slicehas been rewritten to use a conventional C-styleforloop since I didn't want to mess with feature detection.Another change in this pull is that
spec/jasmine-1.0.1directory has been renamed to justspec/jasminesince I was testing with a different version, and though it'd be cleaner this way.Also removed a stray .DS_Store file in the lib directory.
Unit tests pass on all major browers (Windows only, though) + IE8 using Jasmine 1.3.1.
(As originally reported in #8)