-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Errors in username formatting not caught during dry run #20
Comments
It really should! Also, -f doesn't work! I've tried -f 8 to start at issue 8, but it starts at 1 anyway. |
@TurkeyMan the problem with -f comes from Bitbucket's api that are broken, neither "start" nor "limit" work according to the docs. With 17 issues, if I pass -f 15 it copies the first 2 (=17-15) issues. Similarly, limit does not limit anything but it just takes the last X issues |
@jeffwidman: I don't believe it did. The behavior of formatting a comment is still not captured in the dry run. |
Invoke format_comment even in dry run. Fixes #20.
Merged your fix. Thanks! |
In #19, I encountered an error, but only when I tried to run the migration for real. When I ran it using
--dry-run
, the error was not encountered. Dry run should probably catch errors in formatting.The text was updated successfully, but these errors were encountered: