Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors in username formatting not caught during dry run #20

Closed
jaraco opened this issue Feb 4, 2015 · 5 comments
Closed

Errors in username formatting not caught during dry run #20

jaraco opened this issue Feb 4, 2015 · 5 comments

Comments

@jaraco
Copy link
Collaborator

jaraco commented Feb 4, 2015

In #19, I encountered an error, but only when I tried to run the migration for real. When I ran it using --dry-run, the error was not encountered. Dry run should probably catch errors in formatting.

@TurkeyMan
Copy link

It really should!
It's impossible to DELETE bugs from GH >_< .. you can only 'close' them...
So if this stuff's up, you've stuffed your bug database.

Also, -f doesn't work! I've tried -f 8 to start at issue 8, but it starts at 1 anyway.

@linuxbandit
Copy link

@TurkeyMan the problem with -f comes from Bitbucket's api that are broken, neither "start" nor "limit" work according to the docs. With 17 issues, if I pass -f 15 it copies the first 2 (=17-15) issues. Similarly, limit does not limit anything but it just takes the last X issues

@jeffwidman
Copy link
Owner

@jaraco did #25 fix this? If not, do you mind submitting your fix as a PR?

I created #32 as a new issue to track the broken -f option.

@jaraco
Copy link
Collaborator Author

jaraco commented Dec 19, 2015

@jeffwidman: I don't believe it did. The behavior of formatting a comment is still not captured in the dry run.

jeffwidman added a commit that referenced this issue Dec 19, 2015
Invoke format_comment even in dry run. Fixes #20.
@jeffwidman
Copy link
Owner

Merged your fix. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants