HighLine.new.ask("Q?"){|q| q.overwrite = true} errors with version 1.6.5

[astounding]

Running gem version 1.6.5 under Ruby 1.9.2 I encounter this:

require 'highline'
answer = HighLine.new.ask("Password:"){|q| q.overwrite = true ; q.echo = '*'}

Result:
Password:
**********You must enter a valid HighLine::String.

The code worked just fine in previous versions, returning the user's input. If I omit the q.overwrite=true part, it works. So something has changed in the overwrite code path that breaks HighLine.

Thanks.

Aaron Gifford

[astounding]

It looks like the issue occurs within get_response after the while loop gathers the input here:

    if @question.overwrite
      @output.print("\r#{ERASE_LINE}")
      @output.flush
    else
      say("\n")
    end

Something's going on with ERASE_LINE it seems that is causing execution of get_response to abort and for ask's line:
@answer = @question.answer_or_default(get_response)
to be called immediately again, thus calling get_response again, after outputting the message, "You must enter a valid HighLine::String."

Aaron out.

[astounding]

Ah, it appears the ERASE_LINE constant is missing. I can't find it anywhere. That would definitely be a problem.

[astounding]

Verified. Whenever highline.rb attempts to reference ERASE_LINE, exception "uninitialized constant Object::ERASE_LINE" is being raised.

[astounding]

For now so HighLine would work for me, I just replaced ERASE_LINE with HighLine.Style('erase_line').code in two places. And once again it works for me.

[astounding]

Closing this issue as issue 18 (pull request) has one possible solution to this bug (and refers back to this issue).