Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make deletion of queue message optional even in success cases #15

Closed
johngriebel opened this issue Mar 6, 2018 · 2 comments
Closed

Comments

@johngriebel
Copy link

Hi,
I'm currently developing using python-sqs-listener, and I've found myself wishing that deleting a queue message after handle_message was optional even when handle_message runs without raising an exception. I envision using this feature almost exclusively during development, but maybe there are use cases that don't want the message deleted after processing even in production code. I would be more than willing to submit a pull request, but I wanted to check in and see how this idea might be received. Thoughts?

@jegesh
Copy link
Owner

jegesh commented Mar 6, 2018 via email

@johngriebel
Copy link
Author

Like I said, I've only personally wished for this during development to test worker code that processes messages. That's fine though, I'm going to close the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants