fix event emitter leak warning #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jehy
reviewed
Nov 29, 2021
src/telegramServer.ts
Outdated
| this.off('EditedMessageText', handler); | ||
| resolve(); | ||
| }; | ||
| this.on('EditedMessageText', handler); |
There was a problem hiding this comment.
I suppose we can simply use once onstead of on - the we don't have to remove listener manually.
jehy
reviewed
Nov 29, 2021
| this.on('AddedUserMessage', () => resolve()); | ||
| this.on('AddedUserCommand', () => resolve()); | ||
| this.on('AddedUserCallbackQuery', () => resolve()); | ||
| const messageHandler = () => { |
There was a problem hiding this comment.
That doesn't look cool but I can't think of a better way too :)
jehy
requested changes
Nov 29, 2021
|
Good point! |
jehy
requested changes
Nov 29, 2021
src/telegramServer.ts
Outdated
| this.on('AddedUserMessage', () => resolve()); | ||
| this.on('AddedUserCommand', () => resolve()); | ||
| this.on('AddedUserCallbackQuery', () => resolve()); | ||
| this.once('AddedUserMessage', () => resolve()); |
There was a problem hiding this comment.
Everything was right here in previous commit version. We wait for any signal and the turn off all emitters and resolve promise.
Now, one emitter will turn itself off but other two will stay and that's not what we expect :)
There was a problem hiding this comment.
Ahh, that's why you "can't think of a better way too"! =)) Indeed!
There was a problem hiding this comment.
Yup. Emitter is a great power which comes with great possibility of shooting your legs off :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a really long integration test suite, that listens a lot on server edit messages. It was giving me these warnings: