Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

request was added as a dependency. Version was bumped to 1.0.3 #6

Merged
merged 1 commit into from
Sep 3, 2018

Conversation

quasiyoke
Copy link
Contributor

How to reproduce the problem

  1. Remove your node_modules/
  2. Install dependencies the way it does npm when your package is some other project's dependency:
    npm install --only=production
  3. Try to run the server:
    node bin/start.js  
  4. You'll see:
    ###
    ### The "request" library is not installed automatically anymore.
    ### But required by "request-promise".
    ###
    ### npm install request --save
    ###
    
    / ... /telegram-test-api/node_modules/request-promise/lib/rp.js:23
        throw err;
        ^
    
    Error: Cannot find module 'request'
    ...
    

Solution

I've added request to dependencies' list. You're able to make sure that you need to specify request in your package.json at request-promise's README:

request became a peer dependency. Thus make sure that request is installed into your project as a direct dependency. (npm install --save request)

source

@coveralls
Copy link

Coverage Status

Coverage remained the same at 89.941% when pulling e8c4f93 on quasiyoke:request-dependency into 56e2f54 on jehy:master.

@jehy jehy merged commit 5e2e325 into jehy:master Sep 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants