Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace TestBot constructor with a procedure #60

Merged
merged 1 commit into from
Nov 29, 2021

Conversation

RB-Lab
Copy link
Contributor

@RB-Lab RB-Lab commented Nov 29, 2021

image
ಠಿ_ಠ

image
ಠ_ಠ

image
(ノಠ益ಠ)ノ彡┻━┻

image
ᕕ( ᐛ )ᕗ

(despite all my frustration ESLint, essentially, right: TestBot looks like a class but it is, in fact, a procedure that attaches side-effects in constructor. Which is misleading and, indeed, took me some mental efforts, when I first saw it)

@coveralls
Copy link

coveralls commented Nov 29, 2021

Coverage Status

Coverage remained the same at 86.957% when pulling 409b9b3 on RB-Lab:rb/rm-test-bot-constructor into e68c987 on jehy:master.

@jehy
Copy link
Owner

jehy commented Nov 29, 2021

Yup, I suppose I was overthinking when made it a constructor :)

@jehy jehy merged commit b7c085e into jehy:master Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants